You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mappjzc (via GitHub)" <gi...@apache.org> on 2023/05/09 17:06:11 UTC

[GitHub] [incubator-devlake] mappjzc opened a new pull request, #5139: GitHub e2e fix

mappjzc opened a new pull request, #5139:
URL: https://github.com/apache/incubator-devlake/pull/5139

   ### Summary
   Github lost the e2e test for ConvertPullRequestReviews.
   And the repo acount is not be used anymore on ExtractApiPullRequestReviews.
   
   ### Screenshots
   ![image](https://github.com/apache/incubator-devlake/assets/2921251/d39ca2c4-85d7-4b93-b0da-d523d7107e40)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh merged pull request #5139: GitHub e2e fix

Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #5139:
URL: https://github.com/apache/incubator-devlake/pull/5139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh commented on a diff in pull request #5139: GitHub e2e fix

Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #5139:
URL: https://github.com/apache/incubator-devlake/pull/5139#discussion_r1189267028


##########
backend/plugins/github/e2e/snapshot_tables/_tool_github_pull_request_comment.csv:
##########
@@ -0,0 +1,31 @@
+id,pull_request_id,body,account_id,created_date,commit_sha,position,type,review_id,status
+github:GithubPrReview:1:277027723,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:05:02.000+00:00,ee1ad289e5af90bd7ee573f2ff1c968e57e3d69b,0,REVIEW,,COMMENTED
+github:GithubPrReview:1:277036116,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:7496278,2019-08-20T09:19:55.000+00:00,ee1ad289e5af90bd7ee573f2ff1c968e57e3d69b,0,REVIEW,,COMMENTED
+github:GithubPrReview:1:277042368,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:30:46.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,0,REVIEW,,COMMENTED
+github:GithubPrReview:1:277042525,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:31:02.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,0,REVIEW,,COMMENTED
+github:GithubPrReview:1:277042640,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:31:13.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,0,REVIEW,,COMMENTED
+github:GithubPrReview:1:277042704,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:31:20.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,0,REVIEW,,COMMENTED
+github:GithubPrReview:1:277042799,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T09:31:30.000+00:00,6fcab0b1193daa957b660215ee5b243f69098c83,0,REVIEW,,COMMENTED
+github:GithubPrReview:1:277048557,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:7496278,2019-08-20T09:41:40.000+00:00,ee1ad289e5af90bd7ee573f2ff1c968e57e3d69b,0,REVIEW,,COMMENTED
+github:GithubPrReview:1:277049738,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:7496278,2019-08-20T09:44:27.000+00:00,73aae70ec916a654a7f20ab89eda872b826292ba,0,REVIEW,,COMMENTED
+github:GithubPrReview:1:277062848,github:GithubPullRequest:1:308859272,"Besides, MaxBlockingTasks and Nonblocking are under race risk , please make them goroutine-safe.",github:GithubAccount:1:7496278,2019-08-20T10:08:17.000+00:00,73aae70ec916a654a7f20ab89eda872b826292ba,0,REVIEW,,COMMENTED
+github:GithubPrReview:1:277073714,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:8923413,2019-08-20T10:31:22.000+00:00,73aae70ec916a654a7f20ab89eda872b826292ba,0,REVIEW,,COMMENTED
+github:GithubPrReview:1:277081346,github:GithubPullRequest:1:308859272,,github:GithubAccount:1:7496278,2019-08-20T10:48:36.000+00:00,58466b12b03a603d9f0331bbcc64a7557b27865d,0,REVIEW,,COMMENTED
+github:GithubPrReview:1:286687335,github:GithubPullRequest:1:316337433,有时间看下我的 comment,github:GithubAccount:1:7496278,2019-09-11T12:07:36.000+00:00,2cef9f56273b2015a0c9a6b96430a6fb695cda94,0,REVIEW,,COMMENTED

Review Comment:
   Can we change all CJK characters into English?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org