You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "jnh5y (via GitHub)" <gi...@apache.org> on 2024/07/03 12:56:59 UTC

[PR] [FLINK-34268] Removing exclusions for FLINK-33676 33805 [flink]

jnh5y opened a new pull request, #25015:
URL: https://github.com/apache/flink/pull/25015

   ## What is the purpose of the change
   
   When FLINK-34268 was initially implemented, FLINK-3367 and FLINK-33805 had not landed.
   
   ## Brief change log
   
   Given that, there were exclusions hard-coded.  This PR removes those.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34268] Removing exclusions for FLINK-33676 33805 [flink]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #25015:
URL: https://github.com/apache/flink/pull/25015


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34268] Removing exclusions for FLINK-33676 33805 [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25015:
URL: https://github.com/apache/flink/pull/25015#issuecomment-2206026193

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5c7a6f9daba85c4128fb0e4856cd62b4eb570c2d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5c7a6f9daba85c4128fb0e4856cd62b4eb570c2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5c7a6f9daba85c4128fb0e4856cd62b4eb570c2d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34268] Removing exclusions for FLINK-33676 33805 [flink]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #25015:
URL: https://github.com/apache/flink/pull/25015#issuecomment-2206065663

   The description in the PR talks about FLINK-3367, but the code explains it's about https://issues.apache.org/jira/browse/FLINK-33676


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34268] Removing exclusions for FLINK-33676 33805 [flink]

Posted by "jnh5y (via GitHub)" <gi...@apache.org>.
jnh5y commented on PR #25015:
URL: https://github.com/apache/flink/pull/25015#issuecomment-2206066717

   > The description in the PR talks about [FLINK-3367](https://issues.apache.org/jira/browse/FLINK-3367), but the code explains it's about https://issues.apache.org/jira/browse/FLINK-33676
   
   Updated!  Sorry for the typos!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org