You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Michael Dürig <md...@apache.org> on 2015/08/04 15:47:08 UTC

Re: svn commit: r1693270 - in /jackrabbit/oak/trunk: oak-authorization-cug/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/cug/ oak-authorization-cug/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/cug/impl/ oak-core/s...


On 29.7.15 4:21 , angela@apache.org wrote:
> Author: angela
> Date: Wed Jul 29 14:21:18 2015
> New Revision: 1693270
>
> URL: http://svn.apache.org/r1693270
> Log:
> OAK-3160 - Implement Session.hasPermission(String, String...) and support for additional actions,
> OAK-2008 :  authorization setup for closed user groups (WIP)
>

>
> Modified: jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/SessionImpl.java
> URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/SessionImpl.java?rev=1693270&r1=1693269&r2=1693270&view=diff
> ==============================================================================
> --- jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/SessionImpl.java (original)
> +++ jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/SessionImpl.java Wed Jul 29 14:21:18 2015
> @@ -69,6 +69,7 @@ import org.apache.jackrabbit.oak.jcr.ses
>   import org.apache.jackrabbit.oak.jcr.xml.ImportHandler;
>   import org.apache.jackrabbit.oak.spi.security.authentication.ImpersonationCredentials;
>   import org.apache.jackrabbit.oak.spi.security.authorization.permission.Permissions;
> +import org.apache.jackrabbit.test.api.util.Text;

This breaks upstream applications as jackrabbit-jcr-tests (which 
contains o.a.j.test.api.util.Text) is declared as optional.

Michael

Re: svn commit: r1693270 - in /jackrabbit/oak/trunk: oak-authorization-cug/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/cug/ oak-authorization-cug/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/cug/impl/ oak-co...

Posted by Michael Dürig <md...@apache.org>.
I fixed the import accordingly at http://svn.apache.org/r1694067

Michael

On 4.8.15 3:55 , Angela Schreiber wrote:
> oh... my bad. it should obviously be the Text utility from jcr-commons
> not the one from the test! sorry...
>
> angela
>
> On 04/08/15 15:47, "Michael Dürig" <md...@apache.org> wrote:
>
>>
>>
>> On 29.7.15 4:21 , angela@apache.org wrote:
>>> Author: angela
>>> Date: Wed Jul 29 14:21:18 2015
>>> New Revision: 1693270
>>>
>>> URL: http://svn.apache.org/r1693270
>>> Log:
>>> OAK-3160 - Implement Session.hasPermission(String, String...) and
>>> support for additional actions,
>>> OAK-2008 :  authorization setup for closed user groups (WIP)
>>>
>>
>>>
>>> Modified:
>>> jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/
>>> session/SessionImpl.java
>>> URL:
>>> http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/main/java/o
>>> rg/apache/jackrabbit/oak/jcr/session/SessionImpl.java?rev=1693270&r1=1693
>>> 269&r2=1693270&view=diff
>>>
>>> =========================================================================
>>> =====
>>> ---
>>> jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/
>>> session/SessionImpl.java (original)
>>> +++
>>> jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/
>>> session/SessionImpl.java Wed Jul 29 14:21:18 2015
>>> @@ -69,6 +69,7 @@ import org.apache.jackrabbit.oak.jcr.ses
>>>    import org.apache.jackrabbit.oak.jcr.xml.ImportHandler;
>>>    import
>>> org.apache.jackrabbit.oak.spi.security.authentication.ImpersonationCreden
>>> tials;
>>>    import
>>> org.apache.jackrabbit.oak.spi.security.authorization.permission.Permissio
>>> ns;
>>> +import org.apache.jackrabbit.test.api.util.Text;
>>
>> This breaks upstream applications as jackrabbit-jcr-tests (which
>> contains o.a.j.test.api.util.Text) is declared as optional.
>>
>> Michael
>

Re: svn commit: r1693270 - in /jackrabbit/oak/trunk: oak-authorization-cug/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/cug/ oak-authorization-cug/src/test/java/org/apache/jackrabbit/oak/spi/security/authorization/cug/impl/ oak-co...

Posted by Angela Schreiber <an...@adobe.com>.
oh... my bad. it should obviously be the Text utility from jcr-commons
not the one from the test! sorry...

angela

On 04/08/15 15:47, "Michael Dürig" <md...@apache.org> wrote:

>
>
>On 29.7.15 4:21 , angela@apache.org wrote:
>> Author: angela
>> Date: Wed Jul 29 14:21:18 2015
>> New Revision: 1693270
>>
>> URL: http://svn.apache.org/r1693270
>> Log:
>> OAK-3160 - Implement Session.hasPermission(String, String...) and
>>support for additional actions,
>> OAK-2008 :  authorization setup for closed user groups (WIP)
>>
>
>>
>> Modified: 
>>jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/
>>session/SessionImpl.java
>> URL: 
>>http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/main/java/o
>>rg/apache/jackrabbit/oak/jcr/session/SessionImpl.java?rev=1693270&r1=1693
>>269&r2=1693270&view=diff
>> 
>>=========================================================================
>>=====
>> --- 
>>jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/
>>session/SessionImpl.java (original)
>> +++ 
>>jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/
>>session/SessionImpl.java Wed Jul 29 14:21:18 2015
>> @@ -69,6 +69,7 @@ import org.apache.jackrabbit.oak.jcr.ses
>>   import org.apache.jackrabbit.oak.jcr.xml.ImportHandler;
>>   import 
>>org.apache.jackrabbit.oak.spi.security.authentication.ImpersonationCreden
>>tials;
>>   import 
>>org.apache.jackrabbit.oak.spi.security.authorization.permission.Permissio
>>ns;
>> +import org.apache.jackrabbit.test.api.util.Text;
>
>This breaks upstream applications as jackrabbit-jcr-tests (which
>contains o.a.j.test.api.util.Text) is declared as optional.
>
>Michael