jUnit5 migration

[Tamas Penzes <ta...@cloudera.com.INVALID>]

Hi All,

My jUnit5 migration on ZooKeeper is almost finished and thought it would be
a good idea to do the same in Curator.
Curator uses testNG, which I don't know in details.
I've checked its page so I know it has some extra features, but I'm not
sure if we use any of them and if they are any not available in jUnit5.

So I'd like to ask you if it worths to migrate to jUnit5 or just
update Curator to use a newer version of testNG?

Regards, Tamaas

Re: jUnit5 migration

[Cameron McKenzie <ca...@apache.org>]

I'm not sure what the benefits of TestNG are over raw JUnit, so I can't
really comment either. Curator has been using TestNG since I've been
contributing to the project. I presume there was some rationale behind
using TestNG though. Jordan?
cheers

On Sun, Aug 9, 2020 at 3:42 PM Enrico Olivelli <eo...@gmail.com> wrote:

> Tamas
>
> Il Sab 8 Ago 2020, 21:40 Tamas Penzes <ta...@cloudera.com.invalid> ha
> scritto:
>
> > Hi All,
> >
> > My jUnit5 migration on ZooKeeper is almost finished and thought it would
> be
> > a good idea to do the same in Curator.
> > Curator uses testNG, which I don't know in details.
> > I've checked its page so I know it has some extra features, but I'm not
> > sure if we use any of them and if they are any not available in jUnit5.
> >
>
> I don't have a strong opinion here, but switching to some modern framework
> would help in keeping the codebase clean and help new contributors.
>
> So +1 from my side.
> I will help you with reviews
>
>
> Enrico
>
>
> > So I'd like to ask you if it worths to migrate to jUnit5 or just
> > update Curator to use a newer version of testNG?
> >
> > Regards, Tamaas
> >
>

Re: jUnit5 migration

[Cameron McKenzie <ca...@apache.org>]

I'm not opposed to it either.  If we're already dependent on JUnit, then
removing a dependency to another library doesn't seem like a bad thing.

So, +1 for me Tamas.
cheers

On Mon, Aug 10, 2020 at 7:47 AM Jordan Zimmerman <jo...@jordanzimmerman.com>
wrote:

> Back when Curator was started, TestNG had many more features. If I were to
> start from scratch today I'd use JUnit 5. But, I don't see much benefit in
> changing now though I'm not opposed to it.
>
> -JZ
>
> > On Aug 9, 2020, at 12:42 AM, Enrico Olivelli <eo...@gmail.com>
> wrote:
> >
> > Tamas
> >
> > Il Sab 8 Ago 2020, 21:40 Tamas Penzes <ta...@cloudera.com.invalid> ha
> > scritto:
> >
> >> Hi All,
> >>
> >> My jUnit5 migration on ZooKeeper is almost finished and thought it
> would be
> >> a good idea to do the same in Curator.
> >> Curator uses testNG, which I don't know in details.
> >> I've checked its page so I know it has some extra features, but I'm not
> >> sure if we use any of them and if they are any not available in jUnit5.
> >>
> >
> > I don't have a strong opinion here, but switching to some modern
> framework
> > would help in keeping the codebase clean and help new contributors.
> >
> > So +1 from my side.
> > I will help you with reviews
> >
> >
> > Enrico
> >
> >
> >> So I'd like to ask you if it worths to migrate to jUnit5 or just
> >> update Curator to use a newer version of testNG?
> >>
> >> Regards, Tamaas
> >>
>
>

Re: jUnit5 migration

[Jordan Zimmerman <jo...@jordanzimmerman.com>]

Back when Curator was started, TestNG had many more features. If I were to start from scratch today I'd use JUnit 5. But, I don't see much benefit in changing now though I'm not opposed to it.

-JZ

> On Aug 9, 2020, at 12:42 AM, Enrico Olivelli <eo...@gmail.com> wrote:
> 
> Tamas
> 
> Il Sab 8 Ago 2020, 21:40 Tamas Penzes <ta...@cloudera.com.invalid> ha
> scritto:
> 
>> Hi All,
>> 
>> My jUnit5 migration on ZooKeeper is almost finished and thought it would be
>> a good idea to do the same in Curator.
>> Curator uses testNG, which I don't know in details.
>> I've checked its page so I know it has some extra features, but I'm not
>> sure if we use any of them and if they are any not available in jUnit5.
>> 
> 
> I don't have a strong opinion here, but switching to some modern framework
> would help in keeping the codebase clean and help new contributors.
> 
> So +1 from my side.
> I will help you with reviews
> 
> 
> Enrico
> 
> 
>> So I'd like to ask you if it worths to migrate to jUnit5 or just
>> update Curator to use a newer version of testNG?
>> 
>> Regards, Tamaas
>> 

Re: jUnit5 migration

[Enrico Olivelli <eo...@gmail.com>]

Tamas

Il Sab 8 Ago 2020, 21:40 Tamas Penzes <ta...@cloudera.com.invalid> ha
scritto:

> Hi All,
>
> My jUnit5 migration on ZooKeeper is almost finished and thought it would be
> a good idea to do the same in Curator.
> Curator uses testNG, which I don't know in details.
> I've checked its page so I know it has some extra features, but I'm not
> sure if we use any of them and if they are any not available in jUnit5.
>

I don't have a strong opinion here, but switching to some modern framework
would help in keeping the codebase clean and help new contributors.

So +1 from my side.
I will help you with reviews


Enrico


> So I'd like to ask you if it worths to migrate to jUnit5 or just
> update Curator to use a newer version of testNG?
>
> Regards, Tamaas
>