You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/27 16:32:19 UTC

[GitHub] [airflow] potiuk opened a new pull request #13328: Also add codecov action to apache airflow repo

potiuk opened a new pull request #13328:
URL: https://github.com/apache/airflow/pull/13328


   Follow up after #13327
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #13328: Also add codecov action to apache airflow repo

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #13328:
URL: https://github.com/apache/airflow/pull/13328#issuecomment-751488876


   > Hm, codecov looks like a entity that may want to have their action as Github approved, I'm not sure if we should keep this one indefinitely
   
   We have no policy for that discussion is ongoing here:
   
   https://lists.apache.org/thread.html/r900f8f9a874006ed8121bdc901a0d1acccbb340882c1f94dad61a5e9%40%3Cusers.infra.apache.org%3E
   
   https://lists.apache.org/thread.html/r435c45dfc28ec74e28314aa9db8a216a2b45ff7f27b15932035d3f65%40%3Cbuilds.apache.org%3E
   
   I have no idea what will be the result of that discussion. For now my main goal is to unblock everyone.
   
   
   The ASF chose to make the change and 'see what happens', we can simply wait until this discussion concludes, but we won't be able to do anything till then,.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #13328: Also add codecov action to apache airflow repo

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13328:
URL: https://github.com/apache/airflow/pull/13328#issuecomment-751488876


   > Hm, codecov looks like a entity that may want to have their action as Github approved, I'm not sure if we should keep this one indefinitely
   
   We have no policy for that discussion is ongoing here:
   
   https://lists.apache.org/thread.html/r900f8f9a874006ed8121bdc901a0d1acccbb340882c1f94dad61a5e9%40%3Cusers.infra.apache.org%3E
   
   https://lists.apache.org/thread.html/r900f8f9a874006ed8121bdc901a0d1acccbb340882c1f94dad61a5e9%40%3Cusers.infra.apache.org%3E
   
   I have no idea what will be the result of that discussion. For now my main goal is to unblock everyone.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #13328: Also add codecov action to apache airflow repo

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13328:
URL: https://github.com/apache/airflow/pull/13328


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek commented on pull request #13328: Also add codecov action to apache airflow repo

Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #13328:
URL: https://github.com/apache/airflow/pull/13328#issuecomment-751488413


   Hm, codecov looks like a entity that may want to have their action as Github approved, I'm not sure if we should keep this one indefinitely 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org