You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Pavitra Subramaniam (JIRA)" <ad...@incubator.apache.org> on 2006/10/19 23:01:36 UTC
[jira] Created: (ADFFACES-248) Propose adding a 'visited' attribute
to the commandNavigationItem component...
Propose adding a 'visited' attribute to the commandNavigationItem component...
------------------------------------------------------------------------------
Key: ADFFACES-248
URL: http://issues.apache.org/jira/browse/ADFFACES-248
Project: MyFaces ADF-Faces
Issue Type: New Feature
Reporter: Pavitra Subramaniam
I would like to propose adding a 'visited' attribute to the commandNavigationItem component.
This attribute is relevant only when used within the train component. We currently have an inaccurate way of figuring out if a stop has been visited or not. The renderer gets the row index of the currently active node and marks every node with an index <= current rowIndex, as 'visited'.
There are many flaws with this approach
- for one it assumes that stops are ordered (iow, they have a sequential flow).
- secondly, the renderer assumes a behavior for the train when it should let the model drive this behavior. For instance, I need to support a use case, where the train stops are all enabled by default and user can jump to any stop. In such situations the above algorithm fails.
A 'visited' API on the component allows the model to set the visited state.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-248) Propose adding a 'visited' attribute
to the commandNavigationItem component...
Posted by "Pavitra Subramaniam (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-248?page=all ]
Pavitra Subramaniam updated ADFFACES-248:
-----------------------------------------
Attachment: Patch248+244.patch
The earlier patch for this issue (248) produced too many conflicts when applied on top of patch 244 (which was commited by Gab) as both are related to the same component.
So I created a new patch on latest Trinidad that includes the commits for issue 244.
> Propose adding a 'visited' attribute to the commandNavigationItem component...
> ------------------------------------------------------------------------------
>
> Key: ADFFACES-248
> URL: http://issues.apache.org/jira/browse/ADFFACES-248
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Pavitra Subramaniam
> Assigned To: Simon Lessard
> Attachments: Issue-248.patch, Patch248+244.patch
>
>
> I would like to propose adding a 'visited' attribute to the commandNavigationItem component.
> This attribute is relevant only when used within the train component. We currently have an inaccurate way of figuring out if a stop has been visited or not. The renderer gets the row index of the currently active node and marks every node with an index <= current rowIndex, as 'visited'.
> There are many flaws with this approach
> - for one it assumes that stops are ordered (iow, they have a sequential flow).
> - secondly, the renderer assumes a behavior for the train when it should let the model drive this behavior. For instance, I need to support a use case, where the train stops are all enabled by default and user can jump to any stop. In such situations the above algorithm fails.
> A 'visited' API on the component allows the model to set the visited state.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (ADFFACES-248) Propose adding a 'visited'
attribute to the commandNavigationItem component...
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-248?page=all ]
Simon Lessard reassigned ADFFACES-248:
--------------------------------------
Assignee: Simon Lessard
> Propose adding a 'visited' attribute to the commandNavigationItem component...
> ------------------------------------------------------------------------------
>
> Key: ADFFACES-248
> URL: http://issues.apache.org/jira/browse/ADFFACES-248
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Pavitra Subramaniam
> Assigned To: Simon Lessard
>
> I would like to propose adding a 'visited' attribute to the commandNavigationItem component.
> This attribute is relevant only when used within the train component. We currently have an inaccurate way of figuring out if a stop has been visited or not. The renderer gets the row index of the currently active node and marks every node with an index <= current rowIndex, as 'visited'.
> There are many flaws with this approach
> - for one it assumes that stops are ordered (iow, they have a sequential flow).
> - secondly, the renderer assumes a behavior for the train when it should let the model drive this behavior. For instance, I need to support a use case, where the train stops are all enabled by default and user can jump to any stop. In such situations the above algorithm fails.
> A 'visited' API on the component allows the model to set the visited state.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (ADFFACES-248) Propose adding a 'visited' attribute
to the commandNavigationItem component...
Posted by "Gabrielle Crawford (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-248?page=all ]
Gabrielle Crawford closed ADFFACES-248.
---------------------------------------
patch applied
> Propose adding a 'visited' attribute to the commandNavigationItem component...
> ------------------------------------------------------------------------------
>
> Key: ADFFACES-248
> URL: http://issues.apache.org/jira/browse/ADFFACES-248
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Pavitra Subramaniam
> Assigned To: Gabrielle Crawford
> Attachments: Issue-248.patch, Patch248+244.patch
>
>
> I would like to propose adding a 'visited' attribute to the commandNavigationItem component.
> This attribute is relevant only when used within the train component. We currently have an inaccurate way of figuring out if a stop has been visited or not. The renderer gets the row index of the currently active node and marks every node with an index <= current rowIndex, as 'visited'.
> There are many flaws with this approach
> - for one it assumes that stops are ordered (iow, they have a sequential flow).
> - secondly, the renderer assumes a behavior for the train when it should let the model drive this behavior. For instance, I need to support a use case, where the train stops are all enabled by default and user can jump to any stop. In such situations the above algorithm fails.
> A 'visited' API on the component allows the model to set the visited state.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-248) Propose adding a 'visited' attribute
to the commandNavigationItem component...
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-248:
----------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> Propose adding a 'visited' attribute to the commandNavigationItem component...
> ------------------------------------------------------------------------------
>
> Key: ADFFACES-248
> URL: https://issues.apache.org/jira/browse/ADFFACES-248
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Affects Versions: 1.0.0-incubating-core
> Reporter: Pavitra Subramaniam
> Assigned To: Gabrielle Crawford
> Fix For: 1.0.0-incubating-core
>
> Attachments: Issue-248.patch, Patch248+244.patch
>
>
> I would like to propose adding a 'visited' attribute to the commandNavigationItem component.
> This attribute is relevant only when used within the train component. We currently have an inaccurate way of figuring out if a stop has been visited or not. The renderer gets the row index of the currently active node and marks every node with an index <= current rowIndex, as 'visited'.
> There are many flaws with this approach
> - for one it assumes that stops are ordered (iow, they have a sequential flow).
> - secondly, the renderer assumes a behavior for the train when it should let the model drive this behavior. For instance, I need to support a use case, where the train stops are all enabled by default and user can jump to any stop. In such situations the above algorithm fails.
> A 'visited' API on the component allows the model to set the visited state.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ADFFACES-248) Propose adding a 'visited'
attribute to the commandNavigationItem component...
Posted by "Gabrielle Crawford (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-248?page=all ]
Gabrielle Crawford reassigned ADFFACES-248:
-------------------------------------------
Assignee: Gabrielle Crawford (was: Simon Lessard)
> Propose adding a 'visited' attribute to the commandNavigationItem component...
> ------------------------------------------------------------------------------
>
> Key: ADFFACES-248
> URL: http://issues.apache.org/jira/browse/ADFFACES-248
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Pavitra Subramaniam
> Assigned To: Gabrielle Crawford
> Attachments: Issue-248.patch, Patch248+244.patch
>
>
> I would like to propose adding a 'visited' attribute to the commandNavigationItem component.
> This attribute is relevant only when used within the train component. We currently have an inaccurate way of figuring out if a stop has been visited or not. The renderer gets the row index of the currently active node and marks every node with an index <= current rowIndex, as 'visited'.
> There are many flaws with this approach
> - for one it assumes that stops are ordered (iow, they have a sequential flow).
> - secondly, the renderer assumes a behavior for the train when it should let the model drive this behavior. For instance, I need to support a use case, where the train stops are all enabled by default and user can jump to any stop. In such situations the above algorithm fails.
> A 'visited' API on the component allows the model to set the visited state.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-248) Propose adding a 'visited' attribute
to the commandNavigationItem component...
Posted by "Pavitra Subramaniam (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-248?page=all ]
Pavitra Subramaniam updated ADFFACES-248:
-----------------------------------------
Attachment: Issue-248.patch
I have provided an SVN patch for this issue. The patch includes the following changes
- Added a visited attribute to the commandNavigationItem component. This property is only used only when used within a train.
- Changed the train code to read visited proeprty through EL. Also updated ProcessMenuModel and ProcessUtils to determine the visited-ness of a stop.
- Updated the demo pages for train and the test scripts
> Propose adding a 'visited' attribute to the commandNavigationItem component...
> ------------------------------------------------------------------------------
>
> Key: ADFFACES-248
> URL: http://issues.apache.org/jira/browse/ADFFACES-248
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Pavitra Subramaniam
> Assigned To: Simon Lessard
> Attachments: Issue-248.patch
>
>
> I would like to propose adding a 'visited' attribute to the commandNavigationItem component.
> This attribute is relevant only when used within the train component. We currently have an inaccurate way of figuring out if a stop has been visited or not. The renderer gets the row index of the currently active node and marks every node with an index <= current rowIndex, as 'visited'.
> There are many flaws with this approach
> - for one it assumes that stops are ordered (iow, they have a sequential flow).
> - secondly, the renderer assumes a behavior for the train when it should let the model drive this behavior. For instance, I need to support a use case, where the train stops are all enabled by default and user can jump to any stop. In such situations the above algorithm fails.
> A 'visited' API on the component allows the model to set the visited state.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (ADFFACES-248) Propose adding a 'visited'
attribute to the commandNavigationItem component...
Posted by "Gabrielle Crawford (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-248?page=all ]
Gabrielle Crawford resolved ADFFACES-248.
-----------------------------------------
Resolution: Fixed
patch applied.
> Propose adding a 'visited' attribute to the commandNavigationItem component...
> ------------------------------------------------------------------------------
>
> Key: ADFFACES-248
> URL: http://issues.apache.org/jira/browse/ADFFACES-248
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Pavitra Subramaniam
> Assigned To: Gabrielle Crawford
> Attachments: Issue-248.patch, Patch248+244.patch
>
>
> I would like to propose adding a 'visited' attribute to the commandNavigationItem component.
> This attribute is relevant only when used within the train component. We currently have an inaccurate way of figuring out if a stop has been visited or not. The renderer gets the row index of the currently active node and marks every node with an index <= current rowIndex, as 'visited'.
> There are many flaws with this approach
> - for one it assumes that stops are ordered (iow, they have a sequential flow).
> - secondly, the renderer assumes a behavior for the train when it should let the model drive this behavior. For instance, I need to support a use case, where the train stops are all enabled by default and user can jump to any stop. In such situations the above algorithm fails.
> A 'visited' API on the component allows the model to set the visited state.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira