[GitHub] [incubator-kvrocks] torwig commented on a diff in pull request #1418: support sync migration

["torwig (via GitHub)" <gi...@apache.org>]

torwig commented on code in PR #1418:
URL: https://github.com/apache/incubator-kvrocks/pull/1418#discussion_r1185110418


##########
src/commands/cmd_cluster.cc:
##########
@@ -253,6 +278,10 @@ class CommandClusterX : public Commander {
   int64_t slot_ = -1;
   int slot_id_ = -1;
   bool force_ = false;
+
+  bool sync_migrate_ = false;
+  int sync_migrate_timeout_ = 0;
+  std::shared_ptr<SyncMigrateContext> sync_migrate_ctx_ = nullptr;

Review Comment:
   @ellutionist Great job!
   I just thinking if we need to have `sync_migrate_ctx_` inside CommandClusterX because you just create it and pass it to the `MigrateSlot` function without further use of this object.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org