Re: svn commit: r915378 - in /subversion/trunk: notes/wc-ng/transitions subversion/libsvn_wc/wc-queries.sql subversion/libsvn_wc/wc_db.c

[Greg Stein <gs...@gmail.com>]

On Thu, Mar 11, 2010 at 00:15, Greg Stein <gs...@gmail.com> wrote:
>...
>>> I want both the base and the working presence, the base presence comes
>>> from base_get_info but I couldn't see how to reliably distinguish
>>> working presence from base presence when using _read_info.  I get
>>> SVN_ERR_WC_PATH_NOT_FOUND for no base and no working, and
>>> base_shadowed TRUE for base and working, but it was not clear how to
>>> distinguish base and no working from no base and working.
>>
>> Greg?
>>
>> I think the idea was that you always should be able to tell the difference
>> from the status?
>
> read_info() on its own... no, you cannot always tell. status=normal
> could refer to a BASE node, or a WORKING node (and base_shadowed could
> be FALSE for these two cases).

This comment is wrong. status=normal means an unmodified BASE node. If
there is a WORKING node, then another status will always be returned.

I'm about to remove db_working_get_status(), since I'm in that code to
fix an incorrect scan_addition call.

Cheers,
-g