You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "hertzsprung (via GitHub)" <gi...@apache.org> on 2023/05/04 10:40:54 UTC
[GitHub] [kafka] hertzsprung opened a new pull request, #13671: KAFKA-14967: fix NPE in CreateTopicsResult
hertzsprung opened a new pull request, #13671:
URL: https://github.com/apache/kafka/pull/13671
instead of passing `null` to the future, pass a populated `TopicAndMetadataConfig`
`MockAdminClient` has no tests that I'm aware of.
The contribution is my original work and that I license the work to the project under the project's open source license.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hertzsprung commented on pull request #13671: KAFKA-14967: fix NPE in MockAdminClient CreateTopicsResult
Posted by "hertzsprung (via GitHub)" <gi...@apache.org>.
hertzsprung commented on PR #13671:
URL: https://github.com/apache/kafka/pull/13671#issuecomment-1535283665
`:clients:test:` succeeded locally but fails in CI due to a gradle configuration problem:
> Could not create task ':clients:test'.
>
> [2023-05-04T16:19:19.121Z]
> The Gradle Enterprise Gradle plugin is conflicting with the Test Retry Gradle plugin and has already added a retry extension to the test task test. Please either remove the Test Retry Gradle plugin from this project or disable the registration of the retry extension in the Gradle Enterprise Gradle plugin by specifying the system property 'gradle.enterprise.testretry.enabled' and setting it to 'false'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #13671: KAFKA-14967: fix NPE in MockAdminClient CreateTopicsResult
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13671:
URL: https://github.com/apache/kafka/pull/13671#issuecomment-1653859939
Thanks @hertzsprung for the PR!
No code in Kafka relies on the content of CreateTopicsResult, and I just realized MockAdminClient is not part of the public API so this is effectively "dead code". That said, I see that we've tried in the past to fix consistency issues between that and the real Admin implementation so I think we can still merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #13671: KAFKA-14967: fix NPE in MockAdminClient CreateTopicsResult
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #13671:
URL: https://github.com/apache/kafka/pull/13671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org