[GitHub] [iceberg] rdblue commented on a change in pull request #1933: Refactor Spark DF read and Write options

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1933:
URL: https://github.com/apache/iceberg/pull/1933#discussion_r546857821



##########
File path: site/docs/spark.md
##########
@@ -347,6 +347,28 @@ df.createOrReplaceTempView("table")
 spark.sql("""select count(1) from table""").show()
 ```
 
+**Note**: Dataframe read options are available as static constants in [SparkReadOptions](https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/types/SparkReadOptions.java) class.
+
+| Spark Read option    | Constant               |
+| --------------- | --------------------- |
+| snapshot-id     | SNAPSHOT_ID              |
+| as-of-timestamp | AS_OF_TIMESTAMP              |
+| split-size      | SPLIT_SIZE |
+| lookback        | LOOKBACK |
+| file-open-cost  | FILE_OPEN_COST |
+| vectorization-enabled  | VECTORIZATION_ENABLED |
+| batch-size  | VECTORIZATION_BATCH_SIZE |
+
+Usage:
+```
+ex: spark

Review comment:
       Can you remove "ex:" here and add the a language to the block so that it is highlighted correctly?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org