[GitHub] sijie closed pull request #1450: BP-33: Move releasing official docker images out of main repo

[GitBox <gi...@apache.org>]

sijie closed pull request #1450: BP-33: Move releasing official docker images out of main repo
URL: https://github.com/apache/bookkeeper/pull/1450
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/site/bps/BP-33-building-official-docker-imags.md b/site/bps/BP-33-building-official-docker-imags.md
new file mode 100644
index 000000000..d50cac1fc
--- /dev/null
+++ b/site/bps/BP-33-building-official-docker-imags.md
@@ -0,0 +1,40 @@
+---
+title: "BP-33: Move releasing official docker images out of main repo"
+issue: https://github.com/apache/bookkeeper/1449
+state: "Under Discussion"
+release: "4.7.1"
+---
+
+### Motivation
+
+Current bookkeeper docker images are auto-built by apache docker account. However it becomes problematic in the release process:
+
+Docker autobuild uses release tag for labeling the versions for docker images. But the `Dockerfile` can only be updated after
+a release is successfully made. So we have to retag a release after a release, in order to update `Dockerfile` to build the docker
+image.
+
+### Proposed Changes
+
+Follow what `flink` is doing, and maintain the docker files outside of the bookkeeper main repo.
+
+- Create an organization `asfbookkeeper-ecosystem` for hosting repos that related bookkeeper but not necessarily needed to be put in main repo.
+- Create a repo `docker-bookkeeper` under `asfbookkeeper-ecosystem` for hosting the docker files following the suggested practices from making a docker official image.
+- Add a library definition file under `docker-library/official-images` for bookkeeper.
+- Add an image doc under `docker-library/docs` for bookkeeper.
+- Update the release guide on how to update docker images at the end of each release.
+- Remove `docker` dir from main repo or make it used for building *unreleased* docker images only.
+- Disable docker autobuild from apache account.
+
+Proposed docker file repo: https://github.com/asfbookkeeper-ecosystem/docker-bookkeeper
+
+### Compatibility, Deprecation, and Migration Plan
+
+N/A
+
+### Test Plan
+
+N/A
+
+### Rejected Alternatives
+
+N/A
diff --git a/site/community/bookkeeper_proposals.md b/site/community/bookkeeper_proposals.md
index dc2fe99c2..425c18e1e 100644
--- a/site/community/bookkeeper_proposals.md
+++ b/site/community/bookkeeper_proposals.md
@@ -85,7 +85,7 @@ using Google Doc.
 
 This section lists all the _bookkeeper proposals_ made to BookKeeper.
 
-*Next Proposal Number: 33*
+*Next Proposal Number: 34*
 
 ### Inprogress
 
@@ -104,6 +104,7 @@ Proposal | State
 [BP-30: BookKeeper Table Service](https://docs.google.com/document/d/155xAwWv5IdOitHh1NVMEwCMGgB28M3FyMiQSxEpjE-Y/edit#heading=h.56rbh52koe3f) | Accepted
 [BP-31: BookKeeper Durability Anchor](../../bps/BP-31-durability) | Accepted
 [BP-32: Advisory (optimistic) write close](../../bps/BP-32-advisory-write-close) | Accepted
+[BP-33: Move releasing docker images out of main repo](../../bps/BP-33-building-official-docker-imags) | Draft
 
 ### Adopted
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services