You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/13 10:20:43 UTC
[GitHub] [incubator-celeborn] pan3793 opened a new pull request, #1070: [ELEBORN-127] Bump Ratis 2.4.1
pan3793 opened a new pull request, #1070:
URL: https://github.com/apache/incubator-celeborn/pull/1070
### What changes were proposed in this pull request?
Bump Ratis 2.4.1
### Why are the changes needed?
Apache Ratis released 2.4.1 recently, it includes bug fixes and improvement.
https://ratis.apache.org/post/2.4.1.html
### What are the items that need reviewer attention?
This PR is target to both main and branch-0.2
### Related issues.
### Related pull requests.
### How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1070: [CELEBORN-127] Bump Ratis 2.4.1
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1070:
URL: https://github.com/apache/incubator-celeborn/pull/1070#issuecomment-1348152489
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1070?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1070](https://codecov.io/gh/apache/incubator-celeborn/pull/1070?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1489cc0) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/97991a34043cff6e5c64218d27c5c0820479b0ea?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (97991a3) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1070 +/- ##
============================================
- Coverage 25.29% 25.26% -0.04%
+ Complexity 776 772 -4
============================================
Files 212 212
Lines 18031 18031
Branches 2036 2036
============================================
- Hits 4561 4555 -6
- Misses 13164 13166 +2
- Partials 306 310 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1070/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `69.26% <0.00%> (-2.46%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1070: [CELEBORN-127] Bump Ratis 2.4.1
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #1070:
URL: https://github.com/apache/incubator-celeborn/pull/1070#issuecomment-1348147099
> I see https://issues.apache.org/jira/browse/RATIS-1743 fixed the memory leak issue, it sounds critical(I didn't took a detail look)
Yea, this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1070: [CELEBORN-127] Bump Ratis 2.4.1
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #1070:
URL: https://github.com/apache/incubator-celeborn/pull/1070#issuecomment-1348146098
I see https://issues.apache.org/jira/browse/RATIS-1743 fixed the memory leak issue, it sounds critical(I didn't took a detail look)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1070: [CELEBORN-127] Bump Ratis 2.4.1
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #1070:
URL: https://github.com/apache/incubator-celeborn/pull/1070#issuecomment-1348138628
cc @SzyWilliam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1070: [CELEBORN-127] Bump Ratis 2.4.1
Posted by GitBox <gi...@apache.org>.
waitinfuture merged PR #1070:
URL: https://github.com/apache/incubator-celeborn/pull/1070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] SzyWilliam commented on pull request #1070: [CELEBORN-127] Bump Ratis 2.4.1
Posted by GitBox <gi...@apache.org>.
SzyWilliam commented on PR #1070:
URL: https://github.com/apache/incubator-celeborn/pull/1070#issuecomment-1348354009
@pan3793 Thanks for working on this! Strong +1 for upgrading. There are no performance degradations or any known bugs introduced. Besides RATIS-1743, there are some other important fixes included in 2.4.1, as:
1. Fix CVE-2022-3171 in [RATIS-1729](https://issues.apache.org/jira/projects/RATIS/issues/RATIS-1729)
2. Reduce AppendEntries latency by 30% in [RATIS-1730](https://issues.apache.org/jira/projects/RATIS/issues/RATIS-1730)
3. Reduce YoungGC by 15% in [RATIS-1717](https://issues.apache.org/jira/projects/RATIS/issues/RATIS-1717)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1070: [CELEBORN-127] Bump Ratis 2.4.1
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #1070:
URL: https://github.com/apache/incubator-celeborn/pull/1070#issuecomment-1348357421
Thanks for confirming @SzyWilliam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org