You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2013/01/18 22:09:38 UTC
Review Request: OOZIE-1180: Separate the connection context details from JMS
Accessor service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9022/
-----------------------------------------------------------
Review request for oozie.
Description
-------
A connection context interface created and a default implementation of it is provided
This addresses bug OOZIE-1180.
https://issues.apache.org/jira/browse/OOZIE-1180
Diffs
-----
branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java PRE-CREATION
branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java PRE-CREATION
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1434998
branches/hcat-intre/core/src/main/resources/oozie-default.xml 1434998
branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1434998
branches/hcat-intre/core/src/test/java/org/apache/oozie/test/XTestCase.java 1434998
Diff: https://reviews.apache.org/r/9022/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request: OOZIE-1180: Separate the connection context details from
JMS Accessor service
Posted by Virag Kothari <vi...@yahoo-inc.com>.
> On Jan. 19, 2013, 12:21 a.m., Mona Chitnis wrote:
> > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java, line 300
> > <https://reviews.apache.org/r/9022/diff/1/?file=250127#file250127line300>
> >
> > Does connectionFactory need to be closed anytime? or will it always stick around?
only connections for a factory can be closed
> On Jan. 19, 2013, 12:21 a.m., Mona Chitnis wrote:
> > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java, line 187
> > <https://reviews.apache.org/r/9022/diff/1/?file=250129#file250129line187>
> >
> > not a good idea to put "axoniteblue" name in open source
removed from the entire file
> On Jan. 19, 2013, 12:21 a.m., Mona Chitnis wrote:
> > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java, line 198
> > <https://reviews.apache.org/r/9022/diff/1/?file=250129#file250129line198>
> >
> > typo exception
corrected
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9022/#review15511
-----------------------------------------------------------
On Jan. 18, 2013, 9:09 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9022/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 9:09 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> A connection context interface created and a default implementation of it is provided
>
>
> This addresses bug OOZIE-1180.
> https://issues.apache.org/jira/browse/OOZIE-1180
>
>
> Diffs
> -----
>
> branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java PRE-CREATION
> branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java PRE-CREATION
> branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1434998
> branches/hcat-intre/core/src/main/resources/oozie-default.xml 1434998
> branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1434998
> branches/hcat-intre/core/src/test/java/org/apache/oozie/test/XTestCase.java 1434998
>
> Diff: https://reviews.apache.org/r/9022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1180: Separate the connection context details from
JMS Accessor service
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9022/#review15511
-----------------------------------------------------------
+1 pending 1 response and minor changes
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java
<https://reviews.apache.org/r/9022/#comment33483>
Does connectionFactory need to be closed anytime? or will it always stick around?
branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
<https://reviews.apache.org/r/9022/#comment33479>
not a good idea to put "axoniteblue" name in open source
branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
<https://reviews.apache.org/r/9022/#comment33480>
same as above
branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
<https://reviews.apache.org/r/9022/#comment33481>
same as above
branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
<https://reviews.apache.org/r/9022/#comment33482>
typo exception
- Mona Chitnis
On Jan. 18, 2013, 9:09 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9022/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 9:09 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> A connection context interface created and a default implementation of it is provided
>
>
> This addresses bug OOZIE-1180.
> https://issues.apache.org/jira/browse/OOZIE-1180
>
>
> Diffs
> -----
>
> branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java PRE-CREATION
> branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java PRE-CREATION
> branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1434998
> branches/hcat-intre/core/src/main/resources/oozie-default.xml 1434998
> branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1434998
> branches/hcat-intre/core/src/test/java/org/apache/oozie/test/XTestCase.java 1434998
>
> Diff: https://reviews.apache.org/r/9022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1180: Separate the connection context details from
JMS Accessor service
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9022/#review15499
-----------------------------------------------------------
Ship it!
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java
<https://reviews.apache.org/r/9022/#comment33463>
Should be private
- Rohini Palaniswamy
On Jan. 18, 2013, 9:09 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9022/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 9:09 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> A connection context interface created and a default implementation of it is provided
>
>
> This addresses bug OOZIE-1180.
> https://issues.apache.org/jira/browse/OOZIE-1180
>
>
> Diffs
> -----
>
> branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java PRE-CREATION
> branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java PRE-CREATION
> branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1434998
> branches/hcat-intre/core/src/main/resources/oozie-default.xml 1434998
> branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1434998
> branches/hcat-intre/core/src/test/java/org/apache/oozie/test/XTestCase.java 1434998
>
> Diff: https://reviews.apache.org/r/9022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1180: Separate the connection context details from
JMS Accessor service
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9022/
-----------------------------------------------------------
(Updated Jan. 18, 2013, 9:09 p.m.)
Review request for oozie.
Description
-------
A connection context interface created and a default implementation of it is provided
This addresses bug OOZIE-1180.
https://issues.apache.org/jira/browse/OOZIE-1180
Diffs
-----
branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java PRE-CREATION
branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java PRE-CREATION
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1434998
branches/hcat-intre/core/src/main/resources/oozie-default.xml 1434998
branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1434998
branches/hcat-intre/core/src/test/java/org/apache/oozie/test/XTestCase.java 1434998
Diff: https://reviews.apache.org/r/9022/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request: OOZIE-1180: Separate the connection context details from
JMS Accessor service
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9022/
-----------------------------------------------------------
(Updated Jan. 18, 2013, 9:09 p.m.)
Review request for oozie.
Description
-------
A connection context interface created and a default implementation of it is provided
This addresses bug OOZIE-1180.
https://issues.apache.org/jira/browse/OOZIE-1180
Diffs
-----
branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java PRE-CREATION
branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java PRE-CREATION
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1434998
branches/hcat-intre/core/src/main/resources/oozie-default.xml 1434998
branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1434998
branches/hcat-intre/core/src/test/java/org/apache/oozie/test/XTestCase.java 1434998
Diff: https://reviews.apache.org/r/9022/diff/
Testing
-------
Thanks,
Virag Kothari