You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "zcsizmadia (via GitHub)" <gi...@apache.org> on 2023/11/19 14:43:34 UTC

[PR] AVRO-3906: Add NET8.0 support [avro]

zcsizmadia opened a new pull request, #2589:
URL: https://github.com/apache/avro/pull/2589

   ## What is the purpose of the change
   
   *Add .NET 8.0 support (AVRO-3906)*
   
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (no)
   - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3906: Add .NET 8.0 support [avro]

Posted by "zcsizmadia (via GitHub)" <gi...@apache.org>.
zcsizmadia commented on PR #2589:
URL: https://github.com/apache/avro/pull/2589#issuecomment-1822785672

   @martin-g This PR fixes AVRO-3909. I wanted to wait for people give some suggestion before I merge, however this PR is fairly simple, so I can go ahead and merge it now to resolve the Newtonsoft vulnerability warning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3906: Add .NET 8.0 support [avro]

Posted by "zcsizmadia (via GitHub)" <gi...@apache.org>.
zcsizmadia merged PR #2589:
URL: https://github.com/apache/avro/pull/2589


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3906: Add .NET 8.0 support [avro]

Posted by "zcsizmadia (via GitHub)" <gi...@apache.org>.
zcsizmadia commented on PR #2589:
URL: https://github.com/apache/avro/pull/2589#issuecomment-1822827125

   Merged. @martin-g if you rebase those failing PRs with main and it should be ok now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3906: Add .NET 8.0 support [avro]

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #2589:
URL: https://github.com/apache/avro/pull/2589#discussion_r1398745240


##########
lang/csharp/versions.props:
##########
@@ -27,14 +27,16 @@
   -->
   <PropertyGroup Label="Latest Package Versions">
     <NewtonsoftJsonVersion>13.0.1</NewtonsoftJsonVersion>
-    <SystemCodeDomVersion>7.0.0</SystemCodeDomVersion>
+    <SystemCodeDomVersion>8.0.0</SystemCodeDomVersion>
     <SystemReflectionVersion>4.3.0</SystemReflectionVersion>
     <SystemReflectionEmitILGenerationVersion>4.7.0</SystemReflectionEmitILGenerationVersion>
     <SystemReflectionEmitLightweightVersion>4.7.0</SystemReflectionEmitLightweightVersion>
 
     <!-- The following packages are required for the extra codec libraries. These are not direct dependencies of the Avro.main library. -->
-    <SharpZipLibVersion>1.4.1</SharpZipLibVersion>
-    <IronSnappyVersion>1.3.0</IronSnappyVersion>
+    <SharpZipLibVersion>1.4.2</SharpZipLibVersion>
+    <IronSnappyVersion>1.3.1</IronSnappyVersion>
+    <!-- As of 11/19/2023, Joveler.Compression.XZ 4.3+ is not compatible with the Linux ARM64 C# github workflow.
+    Keep it at 4.1.0 until the issue is resolved. Maybe the shipped liblzma.so is incompatible? -->

Review Comment:
   Is it worth it to report the issue to the Joveler developers ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3906: Add .NET 8.0 support [avro]

Posted by "zcsizmadia (via GitHub)" <gi...@apache.org>.
zcsizmadia commented on PR #2589:
URL: https://github.com/apache/avro/pull/2589#issuecomment-1817886898

   It seems like there is an issue with the C# ARM64 build if the XZ library package Joveler.Compression.XZ is bumped to the latest. The latest package works on my dev environment and succeeds with the standard github worklows, except on ARM64. Added comment about it in the `versions.props`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3906: Add .NET 8.0 support [avro]

Posted by "zcsizmadia (via GitHub)" <gi...@apache.org>.
zcsizmadia commented on PR #2589:
URL: https://github.com/apache/avro/pull/2589#issuecomment-1822790318

   Fyi, I created #2523 back in September asa preparation for the NET 8 analyzer  warning about it, however it wont be needed any more, I will reject that PR once this is merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] AVRO-3906: Add .NET 8.0 support [avro]

Posted by "zcsizmadia (via GitHub)" <gi...@apache.org>.
zcsizmadia commented on code in PR #2589:
URL: https://github.com/apache/avro/pull/2589#discussion_r1398995411


##########
lang/csharp/versions.props:
##########
@@ -27,14 +27,16 @@
   -->
   <PropertyGroup Label="Latest Package Versions">
     <NewtonsoftJsonVersion>13.0.1</NewtonsoftJsonVersion>
-    <SystemCodeDomVersion>7.0.0</SystemCodeDomVersion>
+    <SystemCodeDomVersion>8.0.0</SystemCodeDomVersion>
     <SystemReflectionVersion>4.3.0</SystemReflectionVersion>
     <SystemReflectionEmitILGenerationVersion>4.7.0</SystemReflectionEmitILGenerationVersion>
     <SystemReflectionEmitLightweightVersion>4.7.0</SystemReflectionEmitLightweightVersion>
 
     <!-- The following packages are required for the extra codec libraries. These are not direct dependencies of the Avro.main library. -->
-    <SharpZipLibVersion>1.4.1</SharpZipLibVersion>
-    <IronSnappyVersion>1.3.0</IronSnappyVersion>
+    <SharpZipLibVersion>1.4.2</SharpZipLibVersion>
+    <IronSnappyVersion>1.3.1</IronSnappyVersion>
+    <!-- As of 11/19/2023, Joveler.Compression.XZ 4.3+ is not compatible with the Linux ARM64 C# github workflow.
+    Keep it at 4.1.0 until the issue is resolved. Maybe the shipped liblzma.so is incompatible? -->

Review Comment:
   Yes, I will. I just wanted to reproduce and investigate before I do that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org