[GitHub] [pulsar] kaushik-develop commented on a change in pull request #10657: [PIP-82] [pulsar-broker] Add resource-group configuration listener.

[GitBox <gi...@apache.org>]

kaushik-develop commented on a change in pull request #10657:
URL: https://github.com/apache/pulsar/pull/10657#discussion_r637114635



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroup.java
##########
@@ -70,9 +70,10 @@
 
     // Default ctor: it is not expected that anything outside of this package will need to directly
     // construct a ResourceGroup (i.e., without going through ResourceGroupService).
-    protected ResourceGroup(ResourceGroupService rgs, ResourceGroupConfigInfo rgConfig) {
+    protected ResourceGroup(ResourceGroupService rgs, String name,
+                            org.apache.pulsar.common.policies.data.ResourceGroup rgConfig) {
         this.rgs = rgs;

Review comment:
       Nit/qs: would it make sense to have the resource-group name within the org.apache.pulsar.common.policies.data.ResourceGroup class? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org