You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "jbonofre (via GitHub)" <gi...@apache.org> on 2026/04/13 11:47:50 UTC
[PR] Fix LICENSE file in the spark plugin bundle jar [polaris]
jbonofre opened a new pull request, #4182:
URL: https://github.com/apache/polaris/pull/4182
As mentioned during 1.4.0 release vote, the spark plugin bundle jar `LICENSE` file mentions some dependencies not actually bundle in the jar.
This PR cleans up these dependencies from the `LICENSE` file.
## Checklist
- [x] ๐ก๏ธ Don't disclose security issues! (contact security@apache.org)
- [x] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes #
- [x] ๐งช Added/updated tests with good coverage, or manually tested (and explained how)
- [x] ๐ก Added comments for complex logic
- [x] ๐งพ Updated `CHANGELOG.md` (if needed)
- [x] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix LICENSE/NOTICE files in the spark plugin bundle jar [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #4182:
URL: https://github.com/apache/polaris/pull/4182#discussion_r3074375465
##########
plugins/spark/v3.5/spark/BUNDLE-LICENSE:
##########
@@ -639,68 +534,6 @@ https://github.com/geotools/geotools/wiki/JTS-Shapefile-Contribution
--------------------------------------------------------------------------------
-This binary artifact contains FastDoubleParser.
Review Comment:
Let me check the relocation of this https://github.com/wrandelshofer/FastDoubleParser/blob/main/fastdoubleparser-dev/src/main/java/ch.randelshofer.fastdoubleparser/ch/randelshofer/fastdoubleparser/AbstractBigDecimalParser.java
##########
plugins/spark/v3.5/spark/BUNDLE-LICENSE:
##########
@@ -639,68 +534,6 @@ https://github.com/geotools/geotools/wiki/JTS-Shapefile-Contribution
--------------------------------------------------------------------------------
-This binary artifact contains FastDoubleParser.
Review Comment:
Let me check the relocation of this https://github.com/wrandelshofer/FastDoubleParser/blob/main/fastdoubleparser-dev/src/main/java/ch.randelshofer.fastdoubleparser/ch/randelshofer/fastdoubleparser/AbstractBigDecimalParser.java for instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix LICENSE/NOTICE files in the spark plugin bundle jar [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #4182:
URL: https://github.com/apache/polaris/pull/4182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix LICENSE/NOTICE files in the spark plugin bundle jar [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #4182:
URL: https://github.com/apache/polaris/pull/4182#issuecomment-4238343383
@flyrain fair point. Let me try to draft a proposal for the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix LICENSE/NOTICE files in the spark plugin bundle jar [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #4182:
URL: https://github.com/apache/polaris/pull/4182#discussion_r3074390598
##########
plugins/spark/v3.5/spark/BUNDLE-LICENSE:
##########
@@ -639,68 +534,6 @@ https://github.com/geotools/geotools/wiki/JTS-Shapefile-Contribution
--------------------------------------------------------------------------------
-This binary artifact contains FastDoubleParser.
Review Comment:
OK, let me keep the initial documentation for FastDoubleParser, which is accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix LICENSE/NOTICE files in the spark plugin bundle jar [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #4182:
URL: https://github.com/apache/polaris/pull/4182#discussion_r3074346739
##########
plugins/spark/v3.5/spark/BUNDLE-LICENSE:
##########
@@ -639,68 +534,6 @@ https://github.com/geotools/geotools/wiki/JTS-Shapefile-Contribution
--------------------------------------------------------------------------------
-This binary artifact contains FastDoubleParser.
Review Comment:
Let me double check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix LICENSE/NOTICE files in the spark plugin bundle jar [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #4182:
URL: https://github.com/apache/polaris/pull/4182#discussion_r3075013758
##########
plugins/spark/v3.5/spark/BUNDLE-LICENSE:
##########
@@ -639,68 +534,6 @@ https://github.com/geotools/geotools/wiki/JTS-Shapefile-Contribution
--------------------------------------------------------------------------------
-This binary artifact contains FastDoubleParser.
Review Comment:
FYI the wrong contents of `META-INF/FastDoubleParser-LICENSE` are not Iceberg's fault, it seems that the issue stems from the Jackson library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix LICENSE/NOTICE files in the spark plugin bundle jar [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #4182:
URL: https://github.com/apache/polaris/pull/4182#discussion_r3074240328
##########
plugins/spark/v3.5/spark/BUNDLE-LICENSE:
##########
@@ -639,68 +534,6 @@ https://github.com/geotools/geotools/wiki/JTS-Shapefile-Contribution
--------------------------------------------------------------------------------
-This binary artifact contains FastDoubleParser.
Review Comment:
This library seems to be present, afaict. It is shaded twice, once by Jackson, once by Parquet + Iceberg:
* org/apache/iceberg/shaded/com/fasterxml/jackson/core/io/doubleparser/
* org/apache/iceberg/shaded/org/apache/parquet/shaded/.../fdp/
##########
plugins/spark/v3.5/spark/BUNDLE-LICENSE:
##########
@@ -639,68 +534,6 @@ https://github.com/geotools/geotools/wiki/JTS-Shapefile-Contribution
--------------------------------------------------------------------------------
-This binary artifact contains FastDoubleParser.
Review Comment:
OK it's probably worse than I thought ๐
I gave this matter to Claude and here is what it said:
> - META-INF/FastDoubleParser-LICENSE โ contains the Apache 2.0 license text (the full ~11 KB Apache 2.0 boilerplate, identical to META-INF/LICENSE). This is clearly a build artifact
> collision in Iceberg's own ShadowJar: when Iceberg shaded multiple JARs each contributing a META-INF/FastDoubleParser-LICENSE, the Apache 2.0 text "won" and overwrote the actual
> FastDoubleParser MIT license.
> - META-INF/FastDoubleParser-NOTICE โ contains the authentic attribution, and it explicitly states "This code is licensed under MIT License" (copyright Werner Randelshofer,
> Switzerland), with a link to the MIT license on GitHub. It also lists the sub-dependencies: fast_double_parser (Apache 2.0), fast_float (Apache 2.0 per this file, MIT per
> META-INF/thirdparty-LICENSE โ fast_float is dual-licensed), and bigint (BSD-2).
>
> The PR author likely inspected the JAR, saw META-INF/FastDoubleParser-LICENSE = Apache 2.0, concluded "it's covered by the top-level Apache 2.0 license", and removed the entry. But
> that file has the wrong content due to an upstream Iceberg ShadowJar collision โ the FastDoubleParser-NOTICE in the same JAR contradicts it by explicitly saying MIT.
>
> My conclusion is unchanged and if anything stronger: FastDoubleParser code is present in the bundle, the correct license for FastDoubleParser is MIT (not Apache 2.0), the
> META-INF/FastDoubleParser-LICENSE that the build excludes is corrupted, and therefore the FastDoubleParser MIT license text must appear in the consolidated BUNDLE-LICENSE. The PR's removal of that entry is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix LICENSE/NOTICE files in the spark plugin bundle jar [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #4182:
URL: https://github.com/apache/polaris/pull/4182#discussion_r3074367098
##########
plugins/spark/v3.5/spark/BUNDLE-LICENSE:
##########
@@ -639,68 +534,6 @@ https://github.com/geotools/geotools/wiki/JTS-Shapefile-Contribution
--------------------------------------------------------------------------------
-This binary artifact contains FastDoubleParser.
Review Comment:
https://github.com/wrandelshofer/FastDoubleParser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org