[GitHub] Ben-Zvi commented on a change in pull request #1450: DRILL-6717: lower and upper functions not works with national characters

[GitBox <gi...@apache.org>]

Ben-Zvi commented on a change in pull request #1450: DRILL-6717: lower and upper functions not works with national characters
URL: https://github.com/apache/drill/pull/1450#discussion_r213520981
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
 ##########
 @@ -529,7 +538,16 @@ public void eval() {
 
 
 Review comment:
   Isn't this too complicated ?   I tried and changed this code by adding here:
   ```
         String orig = new String(buffer.unsafeGetMemory(0,out.end));
         String upp = orig.toUpperCase(/*Locale.GERMAN*/);
         buffer.setBytes(0,upp.getBytes(),0,out.end);
   ```
   and then commented out the whole following *for* loop, and the test passed!
   
   (not sure which one performs better)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services