[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9255: fix: change database save in DatasourceEditor

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #9255: fix: change database save in DatasourceEditor
URL: https://github.com/apache/incubator-superset/pull/9255#discussion_r390439817
 
 

 ##########
 File path: tests/fixtures/datasource.py
 ##########
 @@ -18,6 +18,7 @@
 datasource_post = {
     "id": None,
     "column_formats": {"ratio": ".2%"},
+    "database": {"id": 1},
 
 Review comment:
   Yes, actually here I replace it in the test itself. Not sure what the proper approach here, a function that receives an object and returns a fixture? I'm guessing with DAO abstraction we can get more creative on generating proper fixtures.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org