You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2015/06/08 14:09:00 UTC

[jira] [Commented] (HADOOP-12074) in Shell.java#runCommand() while catching InterruptedException, throw new IOException(ie) instead of IOException(ie.getMessage())

    [ https://issues.apache.org/jira/browse/HADOOP-12074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577093#comment-14577093 ] 

Steve Loughran commented on HADOOP-12074:
-----------------------------------------

Good idea.
I'd recommend going one step further and throwing an {{InterruptedIOException(cause)}} so the caller can act on it without looking inside

> in Shell.java#runCommand() while catching InterruptedException, throw new IOException(ie) instead of IOException(ie.getMessage())
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12074
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Lavkesh Lahngir
>            Assignee: Lavkesh Lahngir
>            Priority: Trivial
>
> Instead of creating IOException with message make InterruptedException the cause of IOException, so that whoever calling shell executor can make use of it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)