You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/12 16:10:06 UTC
[GitHub] [doris] HappenLee opened a new pull request, #13339: [Opt](vec) opt runtime filter for TPCH Q22
HappenLee opened a new pull request, #13339:
URL: https://github.com/apache/doris/pull/13339
1. Support Right Anti Join to generate runtime filter
2. Union the always true logic of runtime filter
3. Rewrite the Q22 and Q14 of TPCH
# Proposed changes
After do the opt
the tpch q22
before : 5.5s
after : 3.5s
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13339: [Opt](vec) opt runtime filter for TPCH Q22
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13339:
URL: https://github.com/apache/doris/pull/13339#issuecomment-1279694121
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13339: [Opt](vec) opt runtime filter for TPCH Q22
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13339:
URL: https://github.com/apache/doris/pull/13339#issuecomment-1279694115
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #13339: [Opt](vec) opt runtime filter for TPCH Q22
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #13339:
URL: https://github.com/apache/doris/pull/13339#discussion_r994152425
##########
be/src/exprs/bloomfilter_predicate.h:
##########
@@ -435,9 +435,7 @@ class BloomFilterPredicate : public Predicate {
std::shared_ptr<BloomFilterFuncBase> _filter;
bool _has_calculate_filter = false;
- // loop size must be power of 2
- constexpr static int64_t _loop_size = 8192;
// if filter rate less than this, bloom filter will set always true
- constexpr static double _expect_filter_rate = 0.2;
+ constexpr static double _expect_filter_rate = 0.5;
Review Comment:
Why set it to 0.5 here but 0.4 in VBloomFilter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee merged pull request #13339: [Opt](vec) opt runtime filter for TPCH Q22
Posted by GitBox <gi...@apache.org>.
HappenLee merged PR #13339:
URL: https://github.com/apache/doris/pull/13339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #13339: [Opt](vec) opt runtime filter for TPCH Q22
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #13339:
URL: https://github.com/apache/doris/pull/13339#discussion_r994432858
##########
be/src/exprs/bloomfilter_predicate.h:
##########
@@ -435,9 +435,7 @@ class BloomFilterPredicate : public Predicate {
std::shared_ptr<BloomFilterFuncBase> _filter;
bool _has_calculate_filter = false;
- // loop size must be power of 2
- constexpr static int64_t _loop_size = 8192;
// if filter rate less than this, bloom filter will set always true
- constexpr static double _expect_filter_rate = 0.2;
+ constexpr static double _expect_filter_rate = 0.5;
Review Comment:
forget to change it to 0.4, need change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13339: [Opt](vec) opt runtime filter for TPCH Q22
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13339:
URL: https://github.com/apache/doris/pull/13339#issuecomment-1279936059
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org