You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/24 23:41:33 UTC

[GitHub] [arrow-datafusion] avantgardnerio commented on pull request #3948: Don't make users install protoc

avantgardnerio commented on PR #3948:
URL: https://github.com/apache/arrow-datafusion/pull/3948#issuecomment-1289784695

   > there are [reasons](https://github.com/tokio-rs/prost/issues/725) prost stopped vending protoc
   
   @tustvold skimming the reasons, it looks like they are down to user control. That made me realize I was overriding user choice. I added new code that does a no-op if the user has already set the `PROTOC` env var to their compiler of choice... does that resolve your concerns with this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org