You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/02/09 21:26:21 UTC

[GitHub] [accumulo] ctubbsii commented on a change in pull request #1918: Drop debug logs to trace in ZooLock

ctubbsii commented on a change in pull request #1918:
URL: https://github.com/apache/accumulo/pull/1918#discussion_r573252758



##########
File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java
##########
@@ -222,9 +222,9 @@ public int compare(String o1, String o2) {
         }
       });
     }
-    if (LOG.isDebugEnabled()) {
-      LOG.debug("Children nodes: {}", validChildren.size());
-      validChildren.forEach(c -> LOG.debug("- {}", c));
+    if (LOG.isTraceEnabled()) {
+      LOG.trace("Children nodes: {}", validChildren.size());
+      validChildren.forEach(c -> LOG.trace("- {}", c));
     }

Review comment:
       This could also be simplified:
   ```suggestion
       LOG.trace("Children nodes (size: {}): {}", validChildren.size(), validChildren);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org