You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by andrusha <gi...@git.apache.org> on 2018/02/16 14:26:43 UTC
[GitHub] spark pull request #20628: Preserve extraJavaOptions ordering
GitHub user andrusha opened a pull request:
https://github.com/apache/spark/pull/20628
Preserve extraJavaOptions ordering
For some JVM options, like `-XX:+UnlockExperimentalVMOptions` ordering is necessary.
## What changes were proposed in this pull request?
Keep original extraJavaOptions ordering, when passing them through environment variables inside the Docker container.
## How was this patch tested?
Ran base branch a couple of times and checked startup command in logs. Ordering differed every time. Added sorting, ordering was consistent to what user had in `extraJavaOptions`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrusha/spark patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20628.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20628
----
commit 6759e9e9f9075427b87fe5071e803c60d7521629
Author: Andrew Korzhuev <ko...@...>
Date: 2018-02-16T14:24:48Z
Preserve extraJavaOptions ordering
For some JVM options, like `-XX:+UnlockExperimentalVMOptions` ordering is necessary.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20628: [SPARK-23449][K8S] Preserve extraJavaOptions ordering
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20628
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87680/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20628: [SPARK-23449][K8S] Preserve extraJavaOptions ordering
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20628
LGTM, pending tests. I hope we can just use spark-submit here at some point.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20628: [SPARK-23449][K8S] Preserve extraJavaOptions ordering
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/20628
also cc @vanzin to verify this change.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20628: [SPARK-23449][K8S] Preserve extraJavaOptions ordering
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20628
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20628: [SPARK-23449][K8S] Preserve extraJavaOptions ordering
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20628
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20628: [SPARK-23449][K8S] Preserve extraJavaOptions ordering
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20628
**[Test build #87680 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87680/testReport)** for PR 20628 at commit [`6759e9e`](https://github.com/apache/spark/commit/6759e9e9f9075427b87fe5071e803c60d7521629).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20628: [SPARK-23449][K8S] Preserve extraJavaOptions ordering
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20628
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20628: [SPARK-23449][K8S] Preserve extraJavaOptions ordering
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20628
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20628: [SPARK-23449][K8S] Preserve extraJavaOptions ordering
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20628
Merging to master / 2.3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20628: [SPARK-23449][K8S] Preserve extraJavaOptions orde...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20628
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20628: [SPARK-23449][K8S] Preserve extraJavaOptions ordering
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20628
**[Test build #87680 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87680/testReport)** for PR 20628 at commit [`6759e9e`](https://github.com/apache/spark/commit/6759e9e9f9075427b87fe5071e803c60d7521629).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org