You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2012/01/16 10:22:13 UTC
[1/2] git commit: WICKET-4333 BreadCrumbPanelLink should accept
subclasses of BreadBrumbPanel
Updated Branches:
refs/heads/wicket-1.5.x f6afe2ae5 -> 0ef0e57d0
WICKET-4333
BreadCrumbPanelLink should accept subclasses of BreadBrumbPanel
Use Args to verify the passed arguments
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0ef0e57d
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0ef0e57d
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0ef0e57d
Branch: refs/heads/wicket-1.5.x
Commit: 0ef0e57d04ae8fcbdcb404fdc28a8aba28382c7c
Parents: e8a3201
Author: martin-g <mg...@apache.org>
Authored: Mon Jan 16 10:21:53 2012 +0100
Committer: martin-g <mg...@apache.org>
Committed: Mon Jan 16 10:21:53 2012 +0100
----------------------------------------------------------------------
.../breadcrumb/panel/BreadCrumbPanelFactory.java | 6 ++----
.../breadcrumb/panel/BreadCrumbPanelLink.java | 11 +++--------
2 files changed, 5 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/0ef0e57d/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/BreadCrumbPanelFactory.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/BreadCrumbPanelFactory.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/BreadCrumbPanelFactory.java
index a5c601b..243dc96 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/BreadCrumbPanelFactory.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/BreadCrumbPanelFactory.java
@@ -19,6 +19,7 @@ package org.apache.wicket.extensions.breadcrumb.panel;
import java.lang.reflect.Constructor;
import org.apache.wicket.extensions.breadcrumb.IBreadCrumbModel;
+import org.apache.wicket.util.lang.Args;
/**
@@ -44,10 +45,7 @@ public final class BreadCrumbPanelFactory implements IBreadCrumbPanelFactory
*/
public BreadCrumbPanelFactory(final Class<? extends BreadCrumbPanel> panelClass)
{
- if (panelClass == null)
- {
- throw new IllegalArgumentException("argument panelClass must be not null");
- }
+ Args.notNull(panelClass, "panelClass");
if (!BreadCrumbPanel.class.isAssignableFrom(panelClass))
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/0ef0e57d/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/BreadCrumbPanelLink.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/BreadCrumbPanelLink.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/BreadCrumbPanelLink.java
index 6906178..f0fb9b9 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/BreadCrumbPanelLink.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/BreadCrumbPanelLink.java
@@ -19,6 +19,7 @@ package org.apache.wicket.extensions.breadcrumb.panel;
import org.apache.wicket.extensions.breadcrumb.BreadCrumbLink;
import org.apache.wicket.extensions.breadcrumb.IBreadCrumbModel;
import org.apache.wicket.extensions.breadcrumb.IBreadCrumbParticipant;
+import org.apache.wicket.util.lang.Args;
/**
* Bread crumb link specifically for {@link BreadCrumbPanel bread crumb panels}. It uses a
@@ -88,14 +89,8 @@ public class BreadCrumbPanelLink extends BreadCrumbLink
{
super(id, breadCrumbModel);
- if (breadCrumbModel == null)
- {
- throw new IllegalArgumentException("argument breadCrumbModel must be not null");
- }
- if (breadCrumbPanelFactory == null)
- {
- throw new IllegalArgumentException("argument breadCrumbPanelFactory must be not null");
- }
+ Args.notNull(breadCrumbModel, "breadCrumbModel");
+ Args.notNull(breadCrumbPanelFactory, "breadCrumbPanelFactory");
this.breadCrumbModel = breadCrumbModel;
this.breadCrumbPanelFactory = breadCrumbPanelFactory;