You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2019/12/21 09:04:39 UTC
[httpcomponents-client] branch master updated: Duplicate resource
name in integration tests caused client resource leak
This is an automated email from the ASF dual-hosted git repository.
olegk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git
The following commit(s) were added to refs/heads/master by this push:
new b34007d Duplicate resource name in integration tests caused client resource leak
b34007d is described below
commit b34007dffd216f135ddf051113e5bda74172cc8e
Author: Oleg Kalnichevski <ol...@apache.org>
AuthorDate: Sat Dec 21 10:04:20 2019 +0100
Duplicate resource name in integration tests caused client resource leak
---
.../hc/client5/testing/async/AbstractHttp1IntegrationTestBase.java | 2 +-
.../test/java/org/apache/hc/client5/testing/async/TestHttp1Async.java | 2 +-
.../org/apache/hc/client5/testing/async/TestHttp1AsyncRedirects.java | 2 +-
.../hc/client5/testing/async/TestHttp1AsyncStatefulConnManagement.java | 2 +-
.../apache/hc/client5/testing/async/TestHttp1ClientAuthentication.java | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/AbstractHttp1IntegrationTestBase.java b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/AbstractHttp1IntegrationTestBase.java
index f9867fb..2a7a51d 100644
--- a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/AbstractHttp1IntegrationTestBase.java
+++ b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/AbstractHttp1IntegrationTestBase.java
@@ -84,7 +84,7 @@ public abstract class AbstractHttp1IntegrationTestBase extends AbstractServerTes
};
@Rule
- public ExternalResource clientResource = new ExternalResource() {
+ public ExternalResource clientBuilderResource = new ExternalResource() {
@Override
protected void before() throws Throwable {
diff --git a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1Async.java b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1Async.java
index 2117f98..96b7be3 100644
--- a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1Async.java
+++ b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1Async.java
@@ -89,7 +89,7 @@ public class TestHttp1Async extends AbstractHttpAsyncFundamentalsTest<CloseableH
};
@Rule
- public ExternalResource clientResource = new ExternalResource() {
+ public ExternalResource clientBuilderResource = new ExternalResource() {
@Override
protected void before() throws Throwable {
diff --git a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncRedirects.java b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncRedirects.java
index 75f0a8d..b6db089 100644
--- a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncRedirects.java
+++ b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncRedirects.java
@@ -110,7 +110,7 @@ public class TestHttp1AsyncRedirects extends AbstractHttpAsyncRedirectsTest<Clos
};
@Rule
- public ExternalResource clientResource = new ExternalResource() {
+ public ExternalResource clientBuilderResource = new ExternalResource() {
@Override
protected void before() throws Throwable {
diff --git a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncStatefulConnManagement.java b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncStatefulConnManagement.java
index 54b27d4..32c68e9 100644
--- a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncStatefulConnManagement.java
+++ b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncStatefulConnManagement.java
@@ -84,7 +84,7 @@ public class TestHttp1AsyncStatefulConnManagement extends AbstractIntegrationTes
};
@Rule
- public ExternalResource clientResource = new ExternalResource() {
+ public ExternalResource clientBuilderResource = new ExternalResource() {
@Override
protected void before() throws Throwable {
diff --git a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1ClientAuthentication.java b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1ClientAuthentication.java
index ac62f9c..5de96b0 100644
--- a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1ClientAuthentication.java
+++ b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1ClientAuthentication.java
@@ -100,7 +100,7 @@ public class TestHttp1ClientAuthentication extends AbstractHttpAsyncClientAuthen
};
@Rule
- public ExternalResource clientResource = new ExternalResource() {
+ public ExternalResource clientBuilderResource = new ExternalResource() {
@Override
protected void before() throws Throwable {