You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/17 19:13:03 UTC
[GitHub] [airflow] aneesh-joseph opened a new pull request #9352: add a scheduler health check command
aneesh-joseph opened a new pull request #9352:
URL: https://github.com/apache/airflow/pull/9352
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
Add a scheduler health check command which could probably be used for kubernetes `livenessProbe` etc
`airflow scheduler_health`
`airflow scheduler_health --silent`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #9352: add a scheduler health check command
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9352:
URL: https://github.com/apache/airflow/pull/9352#issuecomment-667698134
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9352: add a scheduler health check command
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9352:
URL: https://github.com/apache/airflow/pull/9352#issuecomment-645574736
It would be great if it could be integrated with Helm Chart. Please look
https://github.com/apache/airflow/pull/8777/files
https://github.com/apache/airflow/blob/fcff46d8f162b690bae94cde263a16b5d3a73e67/chart/templates/scheduler/scheduler-deployment.yaml#L123-L132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aneesh-joseph commented on pull request #9352: add a scheduler health check command
Posted by GitBox <gi...@apache.org>.
aneesh-joseph commented on pull request #9352:
URL: https://github.com/apache/airflow/pull/9352#issuecomment-645578775
does the command syntax look alright..If so I could try adding a test for the same..The helm chart validates the hostname as well, so maybe we could add an extra flag `--validate-host` which additionally validates if the hostname matches?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org