You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/07/12 18:42:04 UTC

[GitHub] [maven] kwart commented on pull request #767: [MNG-7511] Ensure the degreeOfConcurrency is a positive number in MavenExecutionRequest

kwart commented on PR #767:
URL: https://github.com/apache/maven/pull/767#issuecomment-1182239385

   > I am not convinced by this. It should throw an IAE here. I would expect to fix the source.
   
   To me, it seems like the safest approach.
   
   Another place to put the fix would be the [MavenCli.calculateDegreeOfConcurrencyWithCoreMultiplier(...)](https://github.com/apache/maven/blob/maven-3.8.6/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L1613-L1617) method, but I like the protection in the config object more as it handles more cases without doing harm. 
   
   Still, if you request the change, I can move the fix to the `calculateDegreeOfConcurrencyWithCoreMultiplier(...)` method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org