[jira] [Commented] (TS-913) logging in collation client mode will report with incorrect space warning

["Zhao Yongming (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083983#comment-13083983 ] 

Zhao Yongming commented on TS-913:
----------------------------------

after reading the code, there is nothing that we need to fix in code, but maybe in docs.

when TS try to get the max space allowed, it may take the value from proxy.config.log.max_space_mb_for_orphan_logs, it is depend on:
{code}
  use_orphan_log_space_value =
    (num_collation_clients == 0 ? false :
     (log_object_manager.get_num_objects() == num_collation_clients ? true :
      max_space_mb_for_orphan_logs > max_space_mb_for_logs));
{code}
that is a good idea, we need to update all docs regarding to proxy.config.log.max_space_mb_for_orphan_logs and proxy.config.log.max_space_mb_for_logs, to get this clear.

> logging in collation client mode will report with incorrect space warning
> -------------------------------------------------------------------------
>
>                 Key: TS-913
>                 URL: https://issues.apache.org/jira/browse/TS-913
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Documentation, Logging
>    Affects Versions: 3.1.0
>            Reporter: Zhao Yongming
>
> when collation mode set to 2, you can get a WARNING in traffic.out when server started:
> {code}
> WARNING: Access logging to local log directory suspended - configured space allocation exhausted.
> {code}
> this is by far not the case, it should print something like:
> {code}
> NOTE: Access logging to local log directory suspended - remote collation is activated
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira