You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2016/07/06 15:37:32 UTC

[GitHub] storm pull request #1500: STORM-1913: Additions and Improvements for Trident...

Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1500#discussion_r69755010
  
    --- Diff: storm-core/src/jvm/org/apache/storm/topology/BaseConfigurationDeclarer.java ---
    @@ -56,7 +56,11 @@ public T setNumTasks(Number val) {
     
         @Override
         public T setMemoryLoad(Number onHeap) {
    -        return setMemoryLoad(onHeap, Utils.getDouble(conf.get(Config.TOPOLOGY_COMPONENT_RESOURCES_OFFHEAP_MEMORY_MB)));
    +        if (onHeap != null) {
    +            onHeap = onHeap.doubleValue();
    +            return addConfiguration(Config.TOPOLOGY_COMPONENT_RESOURCES_ONHEAP_MEMORY_MB, onHeap);
    +        }
    +        return null;
    --- End diff --
    
    @HeartSaVioR fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---