You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alan Conway (JIRA)" <qp...@incubator.apache.org> on 2010/06/29 20:49:52 UTC
[jira] Created: (QPID-2708) Separate types library from common
library.
Separate types library from common library.
-------------------------------------------
Key: QPID-2708
URL: https://issues.apache.org/jira/browse/QPID-2708
Project: Qpid
Issue Type: Improvement
Components: C++ Client
Affects Versions: 0.6
Reporter: Alan Conway
Assignee: Alan Conway
Priority: Minor
Symbols from the qpid::types namespace are currently bundled into the common library.
Create a new types library for these symbols, in order to
- make it consistent with our convention of creating a library per namespace.
- make the qpid ABI clear: it consists only of symbols in the messaging + types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2708) Separate types library from common
library.
Posted by "Alan Conway (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Conway updated QPID-2708:
------------------------------
Attachment: libqpidtypes.patch
Create separate qpidtypes library for the qpid::types namespace.
> Separate types library from common library.
> -------------------------------------------
>
> Key: QPID-2708
> URL: https://issues.apache.org/jira/browse/QPID-2708
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Minor
> Attachments: libqpidtypes.patch
>
>
> Symbols from the qpid::types namespace are currently bundled into the common library.
> Create a new types library for these symbols, in order to
> - make it consistent with our convention of creating a library per namespace.
> - make the qpid ABI clear: it consists only of symbols in the messaging + types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2708) Separate types library from common
library.
Posted by "Chuck Rolke (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883715#action_12883715 ]
Chuck Rolke commented on QPID-2708:
-----------------------------------
Didn't we just do this a month ago? We had to back the changes out because it caused a circular dependency on Windows builds. It worked fine on linux builds because the link libraries can refer to each other and be resolved after the libraries are loaded.
Gordon backed the changes out in r945642.
> Separate types library from common library.
> -------------------------------------------
>
> Key: QPID-2708
> URL: https://issues.apache.org/jira/browse/QPID-2708
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Minor
> Attachments: libqpidtypes.patch
>
>
> Symbols from the qpid::types namespace are currently bundled into the common library.
> Create a new types library for these symbols, in order to
> - make it consistent with our convention of creating a library per namespace.
> - make the qpid ABI clear: it consists only of symbols in the messaging + types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2708) Separate types library from common
library.
Posted by "Alan Conway (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Conway updated QPID-2708:
------------------------------
Attachment: libqpidtypes.patch
Patch to create separate library - includes Steve's comments.
> Separate types library from common library.
> -------------------------------------------
>
> Key: QPID-2708
> URL: https://issues.apache.org/jira/browse/QPID-2708
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Minor
> Attachments: libqpidtypes.patch, libqpidtypes.patch
>
>
> Symbols from the qpid::types namespace are currently bundled into the common library.
> Create a new types library for these symbols, in order to
> - make it consistent with our convention of creating a library per namespace.
> - make the qpid ABI clear: it consists only of symbols in the messaging + types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2708) Separate types library from common
library.
Posted by "Alan Conway (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Conway updated QPID-2708:
------------------------------
Attachment: libqpidtypes.patch
Create a separate qpidtypes library.
> Separate types library from common library.
> -------------------------------------------
>
> Key: QPID-2708
> URL: https://issues.apache.org/jira/browse/QPID-2708
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Minor
> Attachments: libqpidtypes.patch
>
>
> Symbols from the qpid::types namespace are currently bundled into the common library.
> Create a new types library for these symbols, in order to
> - make it consistent with our convention of creating a library per namespace.
> - make the qpid ABI clear: it consists only of symbols in the messaging + types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2708) Separate types library from common
library.
Posted by "Alan Conway (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Conway updated QPID-2708:
------------------------------
Attachment: (was: libqpidtypes.patch)
> Separate types library from common library.
> -------------------------------------------
>
> Key: QPID-2708
> URL: https://issues.apache.org/jira/browse/QPID-2708
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Minor
>
> Symbols from the qpid::types namespace are currently bundled into the common library.
> Create a new types library for these symbols, in order to
> - make it consistent with our convention of creating a library per namespace.
> - make the qpid ABI clear: it consists only of symbols in the messaging + types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2708) Separate types library from common
library.
Posted by "Chuck Rolke (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chuck Rolke updated QPID-2708:
------------------------------
Attachment: qpid-cpp-bindings-dotnet_types_fixup.patch
Based at qpid/cpp/bindings/qpid/dotnet, this patch adds the new types dll to the dotnet binding interop dll.
Note that the interop dll is not part of cmake. The project is /clr and the solution shares space with csharp projects that are out of the cmake scope.
Maybe I can convince Ted to apply this patch (generated on windows by TortiseSVN) as it seems to work only from a windows machine.
> Separate types library from common library.
> -------------------------------------------
>
> Key: QPID-2708
> URL: https://issues.apache.org/jira/browse/QPID-2708
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Minor
> Attachments: libqpidtypes.patch, libqpidtypes.patch, qpid-cpp-bindings-dotnet_types_fixup.patch
>
>
> Symbols from the qpid::types namespace are currently bundled into the common library.
> Create a new types library for these symbols, in order to
> - make it consistent with our convention of creating a library per namespace.
> - make the qpid ABI clear: it consists only of symbols in the messaging + types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2708) Separate types library from common
library.
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883705#action_12883705 ]
Steve Huston commented on QPID-2708:
------------------------------------
The patch looks good, with the exception of small issues:
- In qpid/cpp/include/qpid/types/ImportExport.h the
#if defined(CLIENT_EXPORT) || defined (qpidtypes_EXPORTS)
should be
#if defined(TYPES_EXPORT) || defined (qpidtypes_EXPORTS)
- In qpid/cpp/src/CMakeLists.txt are you sure that this is correct:
target_link_libraries(qpidtypes uuid ${qpidtypes_platform_LIBS})
I didn't think uuid was portable. Maybe it should be in the POSIX/Linux section?
> Separate types library from common library.
> -------------------------------------------
>
> Key: QPID-2708
> URL: https://issues.apache.org/jira/browse/QPID-2708
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Minor
> Attachments: libqpidtypes.patch
>
>
> Symbols from the qpid::types namespace are currently bundled into the common library.
> Create a new types library for these symbols, in order to
> - make it consistent with our convention of creating a library per namespace.
> - make the qpid ABI clear: it consists only of symbols in the messaging + types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2708) Separate types library from common
library.
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884027#action_12884027 ]
Steve Huston commented on QPID-2708:
------------------------------------
This looks good to me.
> Separate types library from common library.
> -------------------------------------------
>
> Key: QPID-2708
> URL: https://issues.apache.org/jira/browse/QPID-2708
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Minor
> Attachments: libqpidtypes.patch, libqpidtypes.patch
>
>
> Symbols from the qpid::types namespace are currently bundled into the common library.
> Create a new types library for these symbols, in order to
> - make it consistent with our convention of creating a library per namespace.
> - make the qpid ABI clear: it consists only of symbols in the messaging + types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Resolved: (QPID-2708) Separate types library from common
library.
Posted by "Alan Conway (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Conway resolved QPID-2708.
-------------------------------
Resolution: Fixed
Committed r959419
> Separate types library from common library.
> -------------------------------------------
>
> Key: QPID-2708
> URL: https://issues.apache.org/jira/browse/QPID-2708
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Minor
> Attachments: libqpidtypes.patch, libqpidtypes.patch
>
>
> Symbols from the qpid::types namespace are currently bundled into the common library.
> Create a new types library for these symbols, in order to
> - make it consistent with our convention of creating a library per namespace.
> - make the qpid ABI clear: it consists only of symbols in the messaging + types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2708) Separate types library from common
library.
Posted by "Alan Conway (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884007#action_12884007 ]
Alan Conway commented on QPID-2708:
-----------------------------------
Chuck: this patch fixes the circularity by moving all the UUID code into libqpidtypes on both windows & unix, so the dependency is simply libqpidcommon depends on libqpidtypes.
> Separate types library from common library.
> -------------------------------------------
>
> Key: QPID-2708
> URL: https://issues.apache.org/jira/browse/QPID-2708
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Minor
> Attachments: libqpidtypes.patch, libqpidtypes.patch
>
>
> Symbols from the qpid::types namespace are currently bundled into the common library.
> Create a new types library for these symbols, in order to
> - make it consistent with our convention of creating a library per namespace.
> - make the qpid ABI clear: it consists only of symbols in the messaging + types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2708) Separate types library from common
library.
Posted by "Alan Conway (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Conway updated QPID-2708:
------------------------------
Comment: was deleted
(was: Create separate qpidtypes library for the qpid::types namespace.)
> Separate types library from common library.
> -------------------------------------------
>
> Key: QPID-2708
> URL: https://issues.apache.org/jira/browse/QPID-2708
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Minor
>
> Symbols from the qpid::types namespace are currently bundled into the common library.
> Create a new types library for these symbols, in order to
> - make it consistent with our convention of creating a library per namespace.
> - make the qpid ABI clear: it consists only of symbols in the messaging + types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org