You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "homberghp (via GitHub)" <gi...@apache.org> on 2024/12/30 10:24:49 UTC
[PR] update formatter to handle record closing braces correctly. solves #743 [netbeans]
homberghp opened a new pull request, #8101:
URL: https://github.com/apache/netbeans/pull/8101
# Solves #7043
Effectively moved one line, that corrects the record closing brace error.
The line
```
spaces(cs.spaceWithinMethodDeclParens() ? 1 : 0, true); // solves #7403
```
has been removed in one spot and added in another.
Added tests to validate correct formatting.
Added record code to template text for the editor>formatting>java/spaces form.
I have no clue how the change in line 950 happened, but is white space only.
Editing in the source code done with netbeans 24 or ubuntu 24.04
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] update formatter to handle record closing braces correctly. solves #7043 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8101:
URL: https://github.com/apache/netbeans/pull/8101#issuecomment-2569927675
closing in favor of https://github.com/apache/netbeans/pull/8106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] update formatter to handle record closing braces correctly. solves #7043 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8101:
URL: https://github.com/apache/netbeans/pull/8101#issuecomment-2567328907
@homberghp I moved the new test back into `FormattingTest` and rebased to latest master
https://github.com/mbien/netbeans/commit/8cbbc9b3366282f40f015a13cf5b51e4db7eec64
If you are ok with this I would like to squash it with your changes and create a new PR. Usually I would ask to push into the PR branch but you used master directly - I don't want to break your clone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] update formatter to handle record closing braces correctly. solves #7043 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien closed pull request #8101: update formatter to handle record closing braces correctly. solves #7043
URL: https://github.com/apache/netbeans/pull/8101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists