You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Nigel Daley (JIRA)" <ji...@apache.org> on 2008/01/08 16:41:34 UTC

[jira] Commented: (HADOOP-2547) remove use of 'magic number' in build.xml

    [ https://issues.apache.org/jira/browse/HADOOP-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556917#action_12556917 ] 

Nigel Daley commented on HADOOP-2547:
-------------------------------------

+1 on code review.

> remove use of 'magic number' in build.xml
> -----------------------------------------
>
>                 Key: HADOOP-2547
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2547
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: build
>            Reporter: Hrishikesh
>            Priority: Trivial
>         Attachments: 2547.patch
>
>
> build.xml has a call to touch task as 
>  <touch datetime="01/25/1971 2:00 pm">
> it should be changed to
>  <touch millis="0"> 
> It will avoid using magic values like "01/25/1971 2:00 pm" and make the script easier to understand

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.