You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by schaubl <gi...@git.apache.org> on 2016/07/13 11:45:14 UTC

[GitHub] libcloud pull request #841: OpenStack - ex_create_floating_ip: set the "pool...

GitHub user schaubl opened a pull request:

    https://github.com/apache/libcloud/pull/841

    OpenStack - ex_create_floating_ip: set the "pool" in the returned object

    ## OpenStack: ex_create_floating_ip(): set the "pool" in the returned object
    
    ### Description
    
    I've added the name of the IP pool from which the IP was created instead of always setting this value to `None`.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
    - [ ] ~~Documentation~~
    - [ ] ~~[Tests](http://libcloud.readthedocs.org/en/latest/testing.html)~~
    - [ ] ~~[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)~~
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/schaubl/libcloud patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/841.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #841
    
----
commit 3202364e24f3c2fb7b9c5f88270012bc6115592b
Author: schaubl <sc...@users.noreply.github.com>
Date:   2016-07-13T10:20:45Z

    OpenStack - ex_create_floating_ip: set the "pool" in the returned object

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---