You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/15 15:02:10 UTC
[GitHub] [rocketmq-client-go] ShannonDing opened a new pull request #489: Support log level set and add more log in offset.
ShannonDing opened a new pull request #489:
URL: https://github.com/apache/rocketmq-client-go/pull/489
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-io edited a comment on pull request #489: Support log level set and add more log in offset.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #489:
URL: https://github.com/apache/rocketmq-client-go/pull/489#issuecomment-629284558
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=h1) Report
> Merging [#489](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/95ca9060e0c9c02e9bd66f59f3896f33922cf903&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #489 +/- ##
==========================================
+ Coverage 24.77% 24.82% +0.04%
==========================================
Files 49 49
Lines 5723 5736 +13
==========================================
+ Hits 1418 1424 +6
- Misses 4102 4109 +7
Partials 203 203
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [consumer/offset\_store.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/489/diff?src=pr&el=tree#diff-Y29uc3VtZXIvb2Zmc2V0X3N0b3JlLmdv) | `65.33% <50.00%> (-1.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=footer). Last update [95ca906...5b8fe2c](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-io commented on pull request #489: Support log level set and add more log in offset.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #489:
URL: https://github.com/apache/rocketmq-client-go/pull/489#issuecomment-629284558
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=h1) Report
> Merging [#489](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/95ca9060e0c9c02e9bd66f59f3896f33922cf903&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #489 +/- ##
==========================================
+ Coverage 24.77% 24.82% +0.04%
==========================================
Files 49 49
Lines 5723 5736 +13
==========================================
+ Hits 1418 1424 +6
- Misses 4102 4109 +7
Partials 203 203
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [consumer/offset\_store.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/489/diff?src=pr&el=tree#diff-Y29uc3VtZXIvb2Zmc2V0X3N0b3JlLmdv) | `65.33% <50.00%> (-1.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=footer). Last update [95ca906...5b8fe2c](https://codecov.io/gh/apache/rocketmq-client-go/pull/489?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] ShannonDing merged pull request #489: Support log level set and add more log in offset.
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #489:
URL: https://github.com/apache/rocketmq-client-go/pull/489
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vongosling commented on a change in pull request #489: Support log level set and add more log in offset.
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #489:
URL: https://github.com/apache/rocketmq-client-go/pull/489#discussion_r433583723
##########
File path: consumer/offset_store.go
##########
@@ -255,6 +255,12 @@ func (r *remoteBrokerOffsetStore) persist(mqs []*primitive.MessageQueue) {
rlog.LogKeyUnderlayError: err.Error(),
"offset": off,
})
+ } else {
+ rlog.Info("update offset to broker success", map[string]interface{}{
Review comment:
update offset [to broker], “to broker” is redundant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org