You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/25 03:39:57 UTC
[GitHub] [solr] risdenk opened a new pull request, #1121: SOLR-16363: DirectUpdateHandler2 should not throw UnknownFormatConversionException
risdenk opened a new pull request, #1121:
URL: https://github.com/apache/solr/pull/1121
https://issues.apache.org/jira/browse/SOLR-16363
TODO need to see if I can add a test for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1121: SOLR-16363: DirectUpdateHandler2 should not throw UnknownFormatConversionException
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1121:
URL: https://github.com/apache/solr/pull/1121#issuecomment-1290886169
> We wouldn't even need a test.
I'm going to leave the test - it tests the `IllegalArgumentException` code path in `DirectUpdateHandler2` that doesn't seem to be tested elsewhere. new PR incoming soon w/ `String.format` removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1121: SOLR-16363: DirectUpdateHandler2 should not throw UnknownFormatConversionException
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1121:
URL: https://github.com/apache/solr/pull/1121#issuecomment-1290875313
> Can we please consider not using String.format here at all? String.format is useful when there is non-trivial formatting. I don't think we should use String.format when a trivial String concatenation can do the job. I don't understand why some people reach for more complex tools like this when the language itself is adequate.
hmm good point. I mistakenly hit the merge button on this trying to merge the commons-text one. I can follow up w/ this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1121: SOLR-16363: DirectUpdateHandler2 should not throw UnknownFormatConversionException
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1121:
URL: https://github.com/apache/solr/pull/1121#issuecomment-1290889195
https://github.com/apache/solr/pull/1124 to remove String.format from DirectUpdateHandler2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1121: SOLR-16363: DirectUpdateHandler2 should not throw UnknownFormatConversionException
Posted by GitBox <gi...@apache.org>.
risdenk merged PR #1121:
URL: https://github.com/apache/solr/pull/1121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1121: SOLR-16363: DirectUpdateHandler2 should not throw UnknownFormatConversionException
Posted by GitBox <gi...@apache.org>.
dsmiley commented on PR #1121:
URL: https://github.com/apache/solr/pull/1121#issuecomment-1290873232
Can we please consider not using String.format here at all? String.format is useful when there is non-trivial formatting. I don't think we should use String.format when a trivial String concatenation can do the job. I don't understand why some people reach for more complex tools like this when the language itself is adequate.
We wouldn't even need a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1121: SOLR-16363: DirectUpdateHandler2 should not throw UnknownFormatConversionException
Posted by GitBox <gi...@apache.org>.
dsmiley commented on PR #1121:
URL: https://github.com/apache/solr/pull/1121#issuecomment-1290875227
Wow; let's allow more time to review please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org