You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/09/28 10:58:14 UTC
[GitHub] [james-project] chibenwa opened a new pull request, #1212: JAMES-3827 Improve indexing of email address domains
chibenwa opened a new pull request, #1212:
URL: https://github.com/apache/james-project/pull/1212
Given an email with `bob@domain.tld`
-> `bob@domain.tld` matches
-> `bob` (localpart) matches
-> `domain.tld` (domain) matches
-> `domain` (part of the domain) do not match.
I think we could easily propose a better 'search experience' by improving indexing and searches for domains.
Traps to avoid:
Given `bob@domain.tld` search we should not return results of other addresses of `domain.tld` domain.
Given `domain.tld` search we should not return unrelated search results from the `tld` top-domain.
migration strategy will be aturaly covered upon the OpenSearch migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1212: JAMES-3827 Improve indexing of email address domains
Posted by GitBox <gi...@apache.org>.
quantranhong1999 commented on code in PR #1212:
URL: https://github.com/apache/james-project/pull/1212#discussion_r984432739
##########
mailbox/opensearch/src/main/java/org/apache/james/mailbox/opensearch/json/EMailer.java:
##########
@@ -30,10 +30,19 @@ public class EMailer implements SerializableMessage {
private final Optional<String> name;
private final String address;
+ private final String domain;
- public EMailer(Optional<String> name, String address) {
+ public EMailer(Optional<String> name, String address, String domain) {
this.name = name;
this.address = address;
+ this.domain = la(domain);
+ }
+
+ String la(String s) {
Review Comment:
Can we have a better name for this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1212: JAMES-3827 Improve indexing of email address domains
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #1212:
URL: https://github.com/apache/james-project/pull/1212#issuecomment-1263428714
> And a bit in upgrade-instructions.md?
Not needed for James. People going from 3.7.x to 3.8.0 will reindex their data in OpenSearch...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1212: JAMES-3827 Improve indexing of email address domains
Posted by GitBox <gi...@apache.org>.
chibenwa merged PR #1212:
URL: https://github.com/apache/james-project/pull/1212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org