You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/15 08:07:58 UTC

[GitHub] [kafka] lkokhreidze opened a new pull request #8671: KAFKA-9859 / Add topics generated by KTable FK join to internal topic matching logic

lkokhreidze opened a new pull request #8671:
URL: https://github.com/apache/kafka/pull/8671


   This PR fixes kafka-streams-application-reset tool. Before, kafka-streams-application-reset tool wasn't taking into account topics generated by KTable foreign key join operation.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #8671: KAFKA-9859 / Add topics generated by KTable FK join to internal topic matching logic

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8671:
URL: https://github.com/apache/kafka/pull/8671#issuecomment-629672739


   test this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang merged pull request #8671: KAFKA-9859 / Add topics generated by KTable FK join to internal topic matching logic

Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #8671:
URL: https://github.com/apache/kafka/pull/8671


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on a change in pull request #8671: KAFKA-9859 / Add topics generated by KTable FK join to internal topic matching logic

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on a change in pull request #8671:
URL: https://github.com/apache/kafka/pull/8671#discussion_r426170554



##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -673,11 +673,17 @@ private boolean isInternalTopic(final String topicName) {
         // Even is this is not expected in general, we need to exclude those topics here
         // and don't consider them as internal topics even if they follow the same naming schema.
         // Cf. https://issues.apache.org/jira/browse/KAFKA-7930
-        return !isInputTopic(topicName) && !isIntermediateTopic(topicName)
-            && topicName.startsWith(options.valueOf(applicationIdOption) + "-")
-            && (topicName.endsWith("-changelog") || topicName.endsWith("-repartition")
-                || topicName.endsWith("-subscription-registration-topic")
-                || topicName.endsWith("-subscription-response-topic"));
+        return !isInputTopic(topicName) && !isIntermediateTopic(topicName) && topicName.startsWith(options.valueOf(applicationIdOption) + "-")
+               && matchesInternalTopicFormat(topicName);
+    }
+
+    // visible for testing
+    public boolean matchesInternalTopicFormat(final String topicName) {
+        return topicName.endsWith("-changelog") || topicName.endsWith("-repartition")
+               || topicName.endsWith("-subscription-registration-topic")

Review comment:
       Not a suggestion comment: now looking at this I think maybe we should not add the `-topic` suffix for those topics since we did not for repartition and changelog :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] lkokhreidze commented on pull request #8671: KAFKA-9859 / Add topics generated by KTable FK join to internal topic matching logic

Posted by GitBox <gi...@apache.org>.
lkokhreidze commented on pull request #8671:
URL: https://github.com/apache/kafka/pull/8671#issuecomment-629096618


   Call for review @guozhangwang @mjsax @vvcephei 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org