You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2019/03/09 00:51:55 UTC

[spark] branch master updated: [SPARK-27056][MESOS] Remove start-shuffle-service.sh

This is an automated email from the ASF dual-hosted git repository.

srowen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 326fc74  [SPARK-27056][MESOS] Remove start-shuffle-service.sh
326fc74 is described below

commit 326fc746d37b2bea9009ca6ee9b11713179cd3dd
Author: liuxian <li...@zte.com.cn>
AuthorDate: Fri Mar 8 18:51:38 2019 -0600

    [SPARK-27056][MESOS] Remove start-shuffle-service.sh
    
    ## What changes were proposed in this pull request?
    
     `start-shuffle-service.sh`  was only used by Mesos  before `start-mesos-shuffle-service.sh`.
    Obviously, `start-mesos-shuffle-service.sh` solves some problems, it is better than  `start-shuffle-service.sh`.
    So now we should delete `start-shuffle-service.sh` in case users use it.
    
    ## How was this patch tested?
    N/A
    
    Closes #23975 from 10110346/rmshuffleservice_sh.
    
    Authored-by: liuxian <li...@zte.com.cn>
    Signed-off-by: Sean Owen <se...@databricks.com>
---
 sbin/start-mesos-shuffle-service.sh |  4 ++--
 sbin/start-shuffle-service.sh       | 34 ----------------------------------
 sbin/stop-shuffle-service.sh        | 26 --------------------------
 3 files changed, 2 insertions(+), 62 deletions(-)

diff --git a/sbin/start-mesos-shuffle-service.sh b/sbin/start-mesos-shuffle-service.sh
index 1845845..7b7dc9c 100755
--- a/sbin/start-mesos-shuffle-service.sh
+++ b/sbin/start-mesos-shuffle-service.sh
@@ -17,11 +17,11 @@
 # limitations under the License.
 #
 
-# Starts the Mesos external shuffle server on the machine this script is executed on.
+# Starts the Mesos external shuffle service on the machine this script is executed on.
 # The Mesos external shuffle service detects when an application exits and automatically
 # cleans up its shuffle files.
 #
-# Usage: start-mesos-shuffle-server.sh
+# Usage: start-mesos-shuffle-service.sh
 #
 # Use the SPARK_SHUFFLE_OPTS environment variable to set shuffle service configuration.
 #
diff --git a/sbin/start-shuffle-service.sh b/sbin/start-shuffle-service.sh
deleted file mode 100755
index 793e165..0000000
--- a/sbin/start-shuffle-service.sh
+++ /dev/null
@@ -1,34 +0,0 @@
-#!/usr/bin/env bash
-
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements.  See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License.  You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-# Starts the external shuffle server on the machine this script is executed on.
-#
-# Usage: start-shuffle-server.sh
-#
-# Use the SPARK_SHUFFLE_OPTS environment variable to set shuffle server configuration.
-#
-
-if [ -z "${SPARK_HOME}" ]; then
-  export SPARK_HOME="$(cd "`dirname "$0"`"/..; pwd)"
-fi
-
-. "${SPARK_HOME}/sbin/spark-config.sh"
-. "${SPARK_HOME}/bin/load-spark-env.sh"
-
-exec "${SPARK_HOME}/sbin"/spark-daemon.sh start org.apache.spark.deploy.ExternalShuffleService 1
diff --git a/sbin/stop-shuffle-service.sh b/sbin/stop-shuffle-service.sh
deleted file mode 100755
index 50d69cf..0000000
--- a/sbin/stop-shuffle-service.sh
+++ /dev/null
@@ -1,26 +0,0 @@
-#!/usr/bin/env bash
-
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements.  See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License.  You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-# Stops the external shuffle service on the machine this script is executed on.
-
-if [ -z "${SPARK_HOME}" ]; then
-  export SPARK_HOME="$(cd "`dirname "$0"`"/..; pwd)"
-fi
-
-"${SPARK_HOME}/sbin"/spark-daemon.sh stop org.apache.spark.deploy.ExternalShuffleService 1


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org