You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2017/01/13 18:25:47 UTC
Review Request 55514: Improve "Install Wizard step 2-10" after new
guidelines
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55514/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
Bugs: AMBARI-19536
https://issues.apache.org/jira/browse/AMBARI-19536
Repository: ambari
Description
-------
Should do the following adjustments to integrate with the new style guidelines:
Step 2, as for the contents inside of the white panel:
1. Make the two radio buttons horizontally aligned.
2. Browse file button should be consistent with other buttons
3. Each section title should be readable.
Step 3,
3. "Remove Selected" should be right aligned, also disappear if nothing selected
Warning section should have some margin
Step 7,
5. Advanced configs, collapse of each category should be consistent with configs page after installed
Also, In general, the checkbox and radio buttons are not aligned with related text.
Diffs
-----
ambari-web/app/messages.js bd60f90
ambari-web/app/styles/theme/bootstrap-ambari.css 5b18417
ambari-web/app/styles/wizard.less b3a833d
ambari-web/app/templates/wizard/step1.hbs 6900624
ambari-web/app/templates/wizard/step2.hbs 4912851
ambari-web/app/templates/wizard/step3.hbs 2ba87e1
ambari-web/app/views/wizard/step2_view.js 719227d
Diff: https://reviews.apache.org/r/55514/diff/
Testing
-------
20236 passing (24s)
153 pending
Thanks,
Xi Wang
Re: Review Request 55514: Improve "Install Wizard step 2-10" after new
guidelines
Posted by Vivek Ratnavel Subramanian <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55514/#review161562
-----------------------------------------------------------
Ship it!
Ship It!
- Vivek Ratnavel Subramanian
On Jan. 13, 2017, 6:25 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55514/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 6:25 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
>
>
> Bugs: AMBARI-19536
> https://issues.apache.org/jira/browse/AMBARI-19536
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Should do the following adjustments to integrate with the new style guidelines:
>
> Step 2, as for the contents inside of the white panel:
> 1. Make the two radio buttons horizontally aligned.
> 2. Browse file button should be consistent with other buttons
> 3. Each section title should be readable.
>
> Step 3,
> 3. "Remove Selected" should be right aligned, also disappear if nothing selected
> Warning section should have some margin
>
> Step 7,
> 5. Advanced configs, collapse of each category should be consistent with configs page after installed
>
> Also, In general, the checkbox and radio buttons are not aligned with related text.
>
>
> Diffs
> -----
>
> ambari-web/app/messages.js bd60f90
> ambari-web/app/styles/theme/bootstrap-ambari.css 5b18417
> ambari-web/app/styles/wizard.less b3a833d
> ambari-web/app/templates/wizard/step1.hbs 6900624
> ambari-web/app/templates/wizard/step2.hbs 4912851
> ambari-web/app/templates/wizard/step3.hbs 2ba87e1
> ambari-web/app/views/wizard/step2_view.js 719227d
>
> Diff: https://reviews.apache.org/r/55514/diff/
>
>
> Testing
> -------
>
> 20236 passing (24s)
> 153 pending
>
>
> Thanks,
>
> Xi Wang
>
>