You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2018/05/09 18:08:00 UTC
[jira] [Commented] (SOLR-12337) Remove QueryWrapperFilter
[ https://issues.apache.org/jira/browse/SOLR-12337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469220#comment-16469220 ]
David Smiley commented on SOLR-12337:
-------------------------------------
Patch: {{Removed SolrConstantScoreQuery(new QueryWrapperFilter(}} wrappings around queries that were in fact already constant scoring Queries :-) _shaking my head_ how did we get to this mess?_
TODO unrelated: SolrIndexSearcher.getProcessedFilter passes ScoreMode.COMPLETE instead of COMPLETE_NO_SCORE
I didn't yet remove QueryWrapperFilter; that can be done in another patch. Some tests will need to be removed/adjusted if it is eliminated.
Tests pass.
Could you please take a look [~yseeley@gmail.com]
> Remove QueryWrapperFilter
> -------------------------
>
> Key: SOLR-12337
> URL: https://issues.apache.org/jira/browse/SOLR-12337
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Attachments: SOLR-12337.patch
>
>
> QueryWrapperFilter has not been needed ever since Filter was changed to extend Query -- LUCENE-1518. It was retained because there was at least one place in Lucene that had a Filter/Query distinction, but it was forgotten when Filter moved to Solr. It contains some code that creates a temporary IndexSearcher but forgets to null out the cache on it, and so QueryWrapperFilter can add non-trivial overhead. We should simply remove it altogether.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org