You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Brian Eaton (JIRA)" <ji...@apache.org> on 2008/06/04 00:46:45 UTC
[jira] Created: (SHINDIG-331) makeRequest methods other than GET
and POST do not work
makeRequest methods other than GET and POST do not work
-------------------------------------------------------
Key: SHINDIG-331
URL: https://issues.apache.org/jira/browse/SHINDIG-331
Project: Shindig
Issue Type: Bug
Components: Gadget Rendering Server (Java)
Reporter: Brian Eaton
It's impossible to send request methods other than GET or POST via gadgets.io.makeRequest. There are several bugs in the code that interfere with this.
In io.js:
- we currently decide whether the method to use to send the proxy request should be GET or POST based on the cache refresh interval. The default cache refresh interval is determined based on whether or not there is a post body. That doesn't seem right. My guess is that we should disable caching (refresh interval == 0) any time the method of the request is not GET.
In BasicHttpFetcher.java:
-we only send GET or POST requests. Again, the logic should probably change to check if method != GET.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-331) makeRequest methods other than GET
and POST do not work
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602102#action_12602102 ]
Kevin Brown commented on SHINDIG-331:
-------------------------------------
The first thing that needs to happen is that we need to move BasicHttpFetcher to commons HTTP client, which avoids a lot of the weird issues in BasicHttpFetcher. I've got a patch to do that with http client 3; paul has one with http client 4, though that conflicts with stuff in abdera and would make running social-api and gadgets artifacts side by side difficult.
DELETE and PUT requests shouldn't be cached, but HEAD should be.
In io.js what you're seeing is the method sent to *shindig* not the method sent to the remote site. That is always determined by the METHOD property of opt_params.
> makeRequest methods other than GET and POST do not work
> -------------------------------------------------------
>
> Key: SHINDIG-331
> URL: https://issues.apache.org/jira/browse/SHINDIG-331
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (Java)
> Reporter: Brian Eaton
>
> It's impossible to send request methods other than GET or POST via gadgets.io.makeRequest. There are several bugs in the code that interfere with this.
> In io.js:
> - we currently decide whether the method to use to send the proxy request should be GET or POST based on the cache refresh interval. The default cache refresh interval is determined based on whether or not there is a post body. That doesn't seem right. My guess is that we should disable caching (refresh interval == 0) any time the method of the request is not GET.
> In BasicHttpFetcher.java:
> -we only send GET or POST requests. Again, the logic should probably change to check if method != GET.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.