You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Edward Fancher (Code Review)" <ge...@cloudera.org> on 2017/05/24 16:45:09 UTC
[kudu-CR] Fix flaky test
Edward Fancher has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6976
Change subject: Fix flaky test
......................................................................
Fix flaky test
Looks like the test was setting a fault injection flag before the setup
which was causing the setup to fail. Moving the flag setting to after
the setup, but before Start seems to have done the trick.
We were getting about 1 failure per 1000 runs before this change,
0 per 1000 after.
Dist test job:
http://dist-test.cloudera.org/job?job_id=efan.1495643022.19373
Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
---
M src/kudu/integration-tests/ts_recovery-itest.cc
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/6976/1
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: Fix flaky test TestRestartWithOrphanedReplicates
......................................................................
Fix flaky test TestRestartWithOrphanedReplicates
Looks like the test was setting a fault injection flag before the setup
which was causing the setup to fail. Moving the flag setting to after
the setup, but before Start seems to have done the trick.
We were getting about 1 failure per 1000 runs before this change,
0 per 1000 after.
Dist test job after patch:
http://dist-test.cloudera.org/job?job_id=efan.1495643022.19373
Dist test job before patch with failures:
http://dist-test.cloudera.org/job?job_id=efan.1495149936.30555
Example from a failure log:
I0518 23:26:00.447599 2346 master_service.cc:195] Signed X509 certificate for tserver {username='slave'} at 127.9.10.0:34667
W0518 23:26:00.448045 2529 fault_injection.cc:38] FAULT INJECTION ENABLED!
W0518 23:26:00.448065 2529 fault_injection.cc:39] THIS SERVER MAY CRASH!
E0518 23:26:00.448072 2529 fault_injection.cc:54] Injecting fault: FLAGS_fault_crash_before_append_commit (process will exit)
I0518 23:26:00.448150 2510 heartbeater.cc:380] Master 127.0.0.1:38357 was elected leader, sending a full tablet report...
W0518 23:26:00.450608 2331 connection.cc:462] server connection from 127.9.10.0:34667 recv error: Network error: failed to read from TLS socket: Connection reset by peer (error 104)
W0518 23:26:00.450630 2319 connection.cc:462] client connection to 127.9.10.0:51332 recv error: Network error: failed to read from TLS socket: Connection reset by peer (error 104)
W0518 23:26:00.450822 2331 connection.cc:462] client connection to 127.9.10.0:51332 recv error: Network error: failed to read from TLS socket: Connection reset by peer (error 104)
F0518 23:26:30.315480 2314 test_workload.cc:266] Timed out: Timed out waiting for Table Creation
*** Check failure stack trace: ***
@ 0x7fb089e3b2fd google::LogMessage::Fail() at ??:0
@ 0x7fb089e3d1bd google::LogMessage::SendToLog() at ??:0
@ 0x7fb089e3ae39 google::LogMessage::Flush() at ??:0
@ 0x7fb089e3dc5f google::LogMessageFatal::~LogMessageFatal() at ??:0
@ 0x7fb0943b7492 kudu::TestWorkload::Setup() at ??:0
@ 0x40e68e kudu::TsRecoveryITest_TestRestartWithOrphanedReplicates_Test::TestBody() at /home/efan/src/kudu/build/release/../../src/kudu/integration-tests/ts_recovery-itest.cc:107
@ 0x7fb08ad35af8 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7fb08ad29fc2 testing::Test::Run() at ??:0
@ 0x7fb08ad2a108 testing::TestInfo::Run() at ??:0
@ 0x7fb08ad2a1e5 testing::TestCase::Run() at ??:0
@ 0x7fb08ad2a4c8 testing::internal::UnitTestImpl::RunAllTests() at ??:0
@ 0x7fb08ad36008 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7fb08ad2a7ad testing::UnitTest::Run() at ??:0
@ 0x7fb09416566c main at ??:0
@ 0x7fb088083f45 __libc_start_main at ??:0
@ 0x40dfb9 (unknown) at ??:?
Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Reviewed-on: http://gerrit.cloudera.org:8080/6976
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/integration-tests/ts_recovery-itest.cc
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Fix flaky test TestRestartWithOrphanedReplicates
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Change looks good, I have a few nitpicky comments about, well, comments.
http://gerrit.cloudera.org:8080/#/c/6976/2/src/kudu/integration-tests/ts_recovery-itest.cc
File src/kudu/integration-tests/ts_recovery-itest.cc:
Line 97: // 1. Setup
I don't think this comment really adds any value to this test.
Line 108: cluster_->SetFlag(cluster_->tablet_server(0),
I think a better comment here would be:
// Crash when the WAL contains a replicate message but no corresponding commit.
Line 121: // 3. Validate
I think a better comment here would be:
// Restart the server and check to make sure that the change is eventually applied.
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates
Posted by "Edward Fancher (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6976
to look at the new patch set (#4).
Change subject: Fix flaky test TestRestartWithOrphanedReplicates
......................................................................
Fix flaky test TestRestartWithOrphanedReplicates
Looks like the test was setting a fault injection flag before the setup
which was causing the setup to fail. Moving the flag setting to after
the setup, but before Start seems to have done the trick.
We were getting about 1 failure per 1000 runs before this change,
0 per 1000 after.
Dist test job after patch:
http://dist-test.cloudera.org/job?job_id=efan.1495643022.19373
Dist test job before patch with failures:
http://dist-test.cloudera.org/job?job_id=efan.1495149936.30555
Example from a failure log:
I0518 23:26:00.447599 2346 master_service.cc:195] Signed X509 certificate for tserver {username='slave'} at 127.9.10.0:34667
W0518 23:26:00.448045 2529 fault_injection.cc:38] FAULT INJECTION ENABLED!
W0518 23:26:00.448065 2529 fault_injection.cc:39] THIS SERVER MAY CRASH!
E0518 23:26:00.448072 2529 fault_injection.cc:54] Injecting fault: FLAGS_fault_crash_before_append_commit (process will exit)
I0518 23:26:00.448150 2510 heartbeater.cc:380] Master 127.0.0.1:38357 was elected leader, sending a full tablet report...
W0518 23:26:00.450608 2331 connection.cc:462] server connection from 127.9.10.0:34667 recv error: Network error: failed to read from TLS socket: Connection reset by peer (error 104)
W0518 23:26:00.450630 2319 connection.cc:462] client connection to 127.9.10.0:51332 recv error: Network error: failed to read from TLS socket: Connection reset by peer (error 104)
W0518 23:26:00.450822 2331 connection.cc:462] client connection to 127.9.10.0:51332 recv error: Network error: failed to read from TLS socket: Connection reset by peer (error 104)
F0518 23:26:30.315480 2314 test_workload.cc:266] Timed out: Timed out waiting for Table Creation
*** Check failure stack trace: ***
@ 0x7fb089e3b2fd google::LogMessage::Fail() at ??:0
@ 0x7fb089e3d1bd google::LogMessage::SendToLog() at ??:0
@ 0x7fb089e3ae39 google::LogMessage::Flush() at ??:0
@ 0x7fb089e3dc5f google::LogMessageFatal::~LogMessageFatal() at ??:0
@ 0x7fb0943b7492 kudu::TestWorkload::Setup() at ??:0
@ 0x40e68e kudu::TsRecoveryITest_TestRestartWithOrphanedReplicates_Test::TestBody() at /home/efan/src/kudu/build/release/../../src/kudu/integration-tests/ts_recovery-itest.cc:107
@ 0x7fb08ad35af8 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7fb08ad29fc2 testing::Test::Run() at ??:0
@ 0x7fb08ad2a108 testing::TestInfo::Run() at ??:0
@ 0x7fb08ad2a1e5 testing::TestCase::Run() at ??:0
@ 0x7fb08ad2a4c8 testing::internal::UnitTestImpl::RunAllTests() at ??:0
@ 0x7fb08ad36008 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7fb08ad2a7ad testing::UnitTest::Run() at ??:0
@ 0x7fb09416566c main at ??:0
@ 0x7fb088083f45 __libc_start_main at ??:0
@ 0x40dfb9 (unknown) at ??:?
Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
---
M src/kudu/integration-tests/ts_recovery-itest.cc
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/6976/4
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Fix flaky test TestRestartWithOrphanedReplicates
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6976/1//COMMIT_MSG
Commit Message:
PS1, Line 12: 1 failure per 1000
> Yea, let me stash it on ve0518 and I can do a rerun.
You shouldn't need to do that, you can see your historical runs at http://dist-test.cloudera.org
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Fix flaky test TestRestartWithOrphanedReplicates
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates
Posted by "Edward Fancher (Code Review)" <ge...@cloudera.org>.
Edward Fancher has posted comments on this change.
Change subject: Fix flaky test TestRestartWithOrphanedReplicates
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6976/1//COMMIT_MSG
Commit Message:
PS1, Line 7: Fix flaky test
> it would be nice to add name of the test here
Ok, will do.
PS1, Line 9: Looks like the test was setting a fault injection flag before the setup
: which was causing the setup to fail
> It would be nice to add the error message that the failed setup output into
Ok, will do.
PS1, Line 12: 1 failure per 1000
> Is it possible to add a link to one of those 1-in-1K dist-test failed runs
Yea, let me stash it on ve0518 and I can do a rerun.
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates
Posted by "Edward Fancher (Code Review)" <ge...@cloudera.org>.
Edward Fancher has uploaded a new patch set (#2).
Change subject: Fix flaky test TestRestartWithOrphanedReplicates
......................................................................
Fix flaky test TestRestartWithOrphanedReplicates
Looks like the test was setting a fault injection flag before the setup
which was causing the setup to fail. Moving the flag setting to after
the setup, but before Start seems to have done the trick.
We were getting about 1 failure per 1000 runs before this change,
0 per 1000 after.
Dist test job:
http://dist-test.cloudera.org/job?job_id=efan.1495643022.19373
Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
---
M src/kudu/integration-tests/ts_recovery-itest.cc
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/6976/2
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Fix flaky test
Posted by "Edward Fancher (Code Review)" <ge...@cloudera.org>.
Edward Fancher has abandoned this change.
Change subject: Fix flaky test
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Fix flaky test
Posted by "Edward Fancher (Code Review)" <ge...@cloudera.org>.
Edward Fancher has restored this change.
Change subject: Fix flaky test
......................................................................
Restored
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: restore
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Fix flaky test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Fix flaky test
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6976/1//COMMIT_MSG
Commit Message:
PS1, Line 7: Fix flaky test
it would be nice to add name of the test here
PS1, Line 9: Looks like the test was setting a fault injection flag before the setup
: which was causing the setup to fail
It would be nice to add the error message that the failed setup output into the log.
PS1, Line 12: 1 failure per 1000
Is it possible to add a link to one of those 1-in-1K dist-test failed runs as well?
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates
Posted by "Edward Fancher (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6976
to look at the new patch set (#3).
Change subject: Fix flaky test TestRestartWithOrphanedReplicates
......................................................................
Fix flaky test TestRestartWithOrphanedReplicates
Looks like the test was setting a fault injection flag before the setup
which was causing the setup to fail. Moving the flag setting to after
the setup, but before Start seems to have done the trick.
We were getting about 1 failure per 1000 runs before this change,
0 per 1000 after.
Dist test job after patch:
http://dist-test.cloudera.org/job?job_id=efan.1495643022.19373
Dist test job before patch with failures:
http://dist-test.cloudera.org/job?job_id=efan.1495149936.30555
Example from a failure log:
I0518 23:26:00.447599 2346 master_service.cc:195] Signed X509 certificate for tserver {username='slave'} at 127.9.10.0:34667
W0518 23:26:00.448045 2529 fault_injection.cc:38] FAULT INJECTION ENABLED!
W0518 23:26:00.448065 2529 fault_injection.cc:39] THIS SERVER MAY CRASH!
E0518 23:26:00.448072 2529 fault_injection.cc:54] Injecting fault: FLAGS_fault_crash_before_append_commit (process will exit)
I0518 23:26:00.448150 2510 heartbeater.cc:380] Master 127.0.0.1:38357 was elected leader, sending a full tablet report...
W0518 23:26:00.450608 2331 connection.cc:462] server connection from 127.9.10.0:34667 recv error: Network error: failed to read from TLS socket: Connection reset by peer (error 104)
W0518 23:26:00.450630 2319 connection.cc:462] client connection to 127.9.10.0:51332 recv error: Network error: failed to read from TLS socket: Connection reset by peer (error 104)
W0518 23:26:00.450822 2331 connection.cc:462] client connection to 127.9.10.0:51332 recv error: Network error: failed to read from TLS socket: Connection reset by peer (error 104)
F0518 23:26:30.315480 2314 test_workload.cc:266] Timed out: Timed out waiting for Table Creation
*** Check failure stack trace: ***
@ 0x7fb089e3b2fd google::LogMessage::Fail() at ??:0
@ 0x7fb089e3d1bd google::LogMessage::SendToLog() at ??:0
@ 0x7fb089e3ae39 google::LogMessage::Flush() at ??:0
@ 0x7fb089e3dc5f google::LogMessageFatal::~LogMessageFatal() at ??:0
@ 0x7fb0943b7492 kudu::TestWorkload::Setup() at ??:0
@ 0x40e68e kudu::TsRecoveryITest_TestRestartWithOrphanedReplicates_Test::TestBody() at /home/efan/src/kudu/build/release/../../src/kudu/integration-tests/ts_recovery-itest.cc:107
@ 0x7fb08ad35af8 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7fb08ad29fc2 testing::Test::Run() at ??:0
@ 0x7fb08ad2a108 testing::TestInfo::Run() at ??:0
@ 0x7fb08ad2a1e5 testing::TestCase::Run() at ??:0
@ 0x7fb08ad2a4c8 testing::internal::UnitTestImpl::RunAllTests() at ??:0
@ 0x7fb08ad36008 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7fb08ad2a7ad testing::UnitTest::Run() at ??:0
@ 0x7fb09416566c main at ??:0
@ 0x7fb088083f45 __libc_start_main at ??:0
@ 0x40dfb9 (unknown) at ??:?
Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
---
M src/kudu/integration-tests/ts_recovery-itest.cc
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/6976/3
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Fix flaky test TestRestartWithOrphanedReplicates
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates
Posted by "Edward Fancher (Code Review)" <ge...@cloudera.org>.
Edward Fancher has posted comments on this change.
Change subject: Fix flaky test TestRestartWithOrphanedReplicates
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6976/2/src/kudu/integration-tests/ts_recovery-itest.cc
File src/kudu/integration-tests/ts_recovery-itest.cc:
Line 97: // 1. Setup
> I don't think this comment really adds any value to this test.
I'll remove it.
Line 108: cluster_->SetFlag(cluster_->tablet_server(0),
> I think a better comment here would be:
Ok. I'll replace it.
Line 121: // 3. Validate
> I think a better comment here would be:
Ok, I'll replace it.
--
To view, visit http://gerrit.cloudera.org:8080/6976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes