You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hairong Kuang (JIRA)" <ji...@apache.org> on 2008/05/17 00:17:55 UTC
[jira] Created: (HADOOP-3409) NameNode should save the root inode
into fsimage
NameNode should save the root inode into fsimage
------------------------------------------------
Key: HADOOP-3409
URL: https://issues.apache.org/jira/browse/HADOOP-3409
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Affects Versions: 0.17.0
Reporter: Hairong Kuang
Assignee: Hairong Kuang
Fix For: 0.18.0
Currently namenode does not save the root inode into the image. Therefore the root's attributes like modification time, permission, and quota in the future are not persistent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3409) NameNode should save the root inode
into fsimage
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598069#action_12598069 ]
Hadoop QA commented on HADOOP-3409:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12382323/rootImage1.patch
against trunk revision 657903.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2499/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2499/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2499/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2499/console
This message is automatically generated.
> NameNode should save the root inode into fsimage
> ------------------------------------------------
>
> Key: HADOOP-3409
> URL: https://issues.apache.org/jira/browse/HADOOP-3409
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.4
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.18.0
>
> Attachments: rootImage.patch, rootImage1.patch
>
>
> Currently namenode does not save the root inode into the image. Therefore the root's attributes like modification time, permission, and quota in the future are not persistent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3409) NameNode should save the root inode
into fsimage
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597666#action_12597666 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-3409:
------------------------------------------------
Is it correct that root path has (path.length() == 0) ?
> NameNode should save the root inode into fsimage
> ------------------------------------------------
>
> Key: HADOOP-3409
> URL: https://issues.apache.org/jira/browse/HADOOP-3409
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.18.0
>
> Attachments: rootImage.patch
>
>
> Currently namenode does not save the root inode into the image. Therefore the root's attributes like modification time, permission, and quota in the future are not persistent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3409) NameNode should save the root inode
into fsimage
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599001#action_12599001 ]
Hudson commented on HADOOP-3409:
--------------------------------
Integrated in Hadoop-trunk #499 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/499/])
> NameNode should save the root inode into fsimage
> ------------------------------------------------
>
> Key: HADOOP-3409
> URL: https://issues.apache.org/jira/browse/HADOOP-3409
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.4
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.18.0
>
> Attachments: rootImage.patch, rootImage1.patch
>
>
> Currently namenode does not save the root inode into the image. Therefore the root's attributes like modification time, permission, and quota in the future are not persistent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3409) NameNode should save the root inode
into fsimage
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598078#action_12598078 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-3409:
------------------------------------------------
+1 patch looks good.
> NameNode should save the root inode into fsimage
> ------------------------------------------------
>
> Key: HADOOP-3409
> URL: https://issues.apache.org/jira/browse/HADOOP-3409
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.4
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.18.0
>
> Attachments: rootImage.patch, rootImage1.patch
>
>
> Currently namenode does not save the root inode into the image. Therefore the root's attributes like modification time, permission, and quota in the future are not persistent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3409) NameNode should save the root inode
into fsimage
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-3409:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> NameNode should save the root inode into fsimage
> ------------------------------------------------
>
> Key: HADOOP-3409
> URL: https://issues.apache.org/jira/browse/HADOOP-3409
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.4
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.18.0
>
> Attachments: rootImage.patch, rootImage1.patch
>
>
> Currently namenode does not save the root inode into the image. Therefore the root's attributes like modification time, permission, and quota in the future are not persistent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3409) NameNode should save the root inode
into fsimage
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598003#action_12598003 ]
Hairong Kuang commented on HADOOP-3409:
---------------------------------------
> is it correct that root path has (path.length() == 0)
This how INode.isRoot() is implemented.
> NameNode should save the root inode into fsimage
> ------------------------------------------------
>
> Key: HADOOP-3409
> URL: https://issues.apache.org/jira/browse/HADOOP-3409
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.18.0
>
> Attachments: rootImage.patch
>
>
> Currently namenode does not save the root inode into the image. Therefore the root's attributes like modification time, permission, and quota in the future are not persistent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3409) NameNode should save the root inode
into fsimage
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-3409:
----------------------------------
Attachment: rootImage1.patch
This is a patch with a modified unit test that makes sure that the root is saved to the disk.
> NameNode should save the root inode into fsimage
> ------------------------------------------------
>
> Key: HADOOP-3409
> URL: https://issues.apache.org/jira/browse/HADOOP-3409
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.18.0
>
> Attachments: rootImage.patch, rootImage1.patch
>
>
> Currently namenode does not save the root inode into the image. Therefore the root's attributes like modification time, permission, and quota in the future are not persistent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3409) NameNode should save the root inode
into fsimage
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-3409:
----------------------------------
Attachment: rootImage.patch
A patch that attempts to fix the problem.
> NameNode should save the root inode into fsimage
> ------------------------------------------------
>
> Key: HADOOP-3409
> URL: https://issues.apache.org/jira/browse/HADOOP-3409
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.18.0
>
> Attachments: rootImage.patch
>
>
> Currently namenode does not save the root inode into the image. Therefore the root's attributes like modification time, permission, and quota in the future are not persistent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3409) NameNode should save the root inode
into fsimage
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597989#action_12597989 ]
Hairong Kuang commented on HADOOP-3409:
---------------------------------------
if we take Dhruba's suggestion, then we need to bump up the image version number.
> NameNode should save the root inode into fsimage
> ------------------------------------------------
>
> Key: HADOOP-3409
> URL: https://issues.apache.org/jira/browse/HADOOP-3409
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.18.0
>
> Attachments: rootImage.patch
>
>
> Currently namenode does not save the root inode into the image. Therefore the root's attributes like modification time, permission, and quota in the future are not persistent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3409) NameNode should save the root inode
into fsimage
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-3409:
----------------------------------
Affects Version/s: (was: 0.17.0)
0.16.4
Status: Patch Available (was: Open)
> NameNode should save the root inode into fsimage
> ------------------------------------------------
>
> Key: HADOOP-3409
> URL: https://issues.apache.org/jira/browse/HADOOP-3409
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.4
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.18.0
>
> Attachments: rootImage.patch, rootImage1.patch
>
>
> Currently namenode does not save the root inode into the image. Therefore the root's attributes like modification time, permission, and quota in the future are not persistent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3409) NameNode should save the root inode
into fsimage
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597787#action_12597787 ]
dhruba borthakur commented on HADOOP-3409:
------------------------------------------
In this patch, the loadFSImage method does the following:
if (path.length() == 0) {
// assume that this is the root inode.
}
will it be more explicit if we replace the above piece of code with the following:
if (i == 0) {
// the first entry is always the root inode.
}
> NameNode should save the root inode into fsimage
> ------------------------------------------------
>
> Key: HADOOP-3409
> URL: https://issues.apache.org/jira/browse/HADOOP-3409
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.18.0
>
> Attachments: rootImage.patch
>
>
> Currently namenode does not save the root inode into the image. Therefore the root's attributes like modification time, permission, and quota in the future are not persistent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.