You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/02/03 19:23:57 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3657: Include line and field number in CSV UTF-8 error (#3656)
tustvold opened a new pull request, #3657:
URL: https://github.com/apache/arrow-rs/pull/3657
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3656
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3657: Include line and field number in CSV UTF-8 error (#3656)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3657:
URL: https://github.com/apache/arrow-rs/pull/3657#discussion_r1096190618
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -2231,4 +2231,37 @@ mod tests {
}
}
}
+
+ fn err_test(csv: &[u8], expected: &str) {
+ let schema = Arc::new(Schema::new(vec![
+ Field::new("text1", DataType::Utf8, false),
+ Field::new("text2", DataType::Utf8, false),
+ ]));
+ let buffer = std::io::BufReader::with_capacity(2, Cursor::new(csv));
+ let b = ReaderBuilder::new()
+ .with_schema(schema)
Review Comment:
We need to provide the schema here, as otherwise the schema inference code produces the error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3657: Include line and field number in CSV UTF-8 error (#3656)
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #3657:
URL: https://github.com/apache/arrow-rs/pull/3657#issuecomment-1416765474
Benchmark runs are scheduled for baseline = 25e10ddf0b8b65f0d73142717e7c22ab150d6870 and contender = 7deb35839d55afb77370a41e3395529ddf78bf59. 7deb35839d55afb77370a41e3395529ddf78bf59 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/360b433bcd8f426ea1c32558edd2d1e5...051e20f88dc649eaab2ca67ca8ab09b9/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/49b99d042df24c1299d930476e9be58d...039eb000cb5c4561bd5e8a9e13a3924c/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/0e99825aa86c4f2fa497ce250e6d56ac...52828be1b59f4a859231f60d50e46167/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/eb920f9a3ec6446daa060abe82697fb6...f930634717954901a92e5e499b97e0b3/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3657: Include line and field number in CSV UTF-8 error (#3656)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3657:
URL: https://github.com/apache/arrow-rs/pull/3657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org