[incubator-superset] branch master updated: chore: remove SIP_34_SAVED_QUERIES_UI feature flag (#11175)

[ta...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 2eb400a  chore: remove SIP_34_SAVED_QUERIES_UI feature flag (#11175)
2eb400a is described below

commit 2eb400a2fc9d7f352d7c371b01a027cebceae54c
Author: Lily Kuang <li...@preset.io>
AuthorDate: Tue Oct 6 15:13:41 2020 -0700

    chore: remove SIP_34_SAVED_QUERIES_UI feature flag (#11175)
---
 superset-frontend/src/featureFlags.ts           | 1 -
 superset-frontend/src/views/CRUD/data/common.ts | 3 +--
 superset/views/sql_lab.py                       | 6 +-----
 3 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/superset-frontend/src/featureFlags.ts b/superset-frontend/src/featureFlags.ts
index ffc1e56..46a3455 100644
--- a/superset-frontend/src/featureFlags.ts
+++ b/superset-frontend/src/featureFlags.ts
@@ -27,7 +27,6 @@ export enum FeatureFlag {
   SHARE_QUERIES_VIA_KV_STORE = 'SHARE_QUERIES_VIA_KV_STORE',
   SQLLAB_BACKEND_PERSISTENCE = 'SQLLAB_BACKEND_PERSISTENCE',
   THUMBNAILS = 'THUMBNAILS',
-  SIP_34_SAVED_QUERIES_UI = 'SIP_34_SAVED_QUERIES_UI',
   LISTVIEWS_DEFAULT_CARD_VIEW = 'LISTVIEWS_DEFAULT_CARD_VIEW',
 }
 
diff --git a/superset-frontend/src/views/CRUD/data/common.ts b/superset-frontend/src/views/CRUD/data/common.ts
index 0400a42..9b2194a 100644
--- a/superset-frontend/src/views/CRUD/data/common.ts
+++ b/superset-frontend/src/views/CRUD/data/common.ts
@@ -17,7 +17,6 @@
  * under the License.
  */
 import { t } from '@superset-ui/core';
-import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';
 
 export const commonMenuData = {
   name: t('Data'),
@@ -38,7 +37,7 @@ export const commonMenuData = {
       name: 'Saved Queries',
       label: t('Saved Queries'),
       url: '/savedqueryview/list/',
-      usesRouter: isFeatureEnabled(FeatureFlag.SIP_34_SAVED_QUERIES_UI),
+      usesRouter: true,
     },
   ],
 };
diff --git a/superset/views/sql_lab.py b/superset/views/sql_lab.py
index 63df0ae..81ec4fe 100644
--- a/superset/views/sql_lab.py
+++ b/superset/views/sql_lab.py
@@ -23,7 +23,6 @@ from flask_babel import lazy_gettext as _
 
 from superset import app, db
 from superset.constants import RouteMethod
-from superset.extensions import feature_flag_manager
 from superset.models.sql_lab import Query, SavedQuery, TableSchema, TabState
 from superset.typing import FlaskResponse
 from superset.utils import core as utils
@@ -79,10 +78,7 @@ class SavedQueryView(
     @expose("/list/")
     @has_access
     def list(self) -> FlaskResponse:
-        if not (
-            app.config["ENABLE_REACT_CRUD_VIEWS"]
-            and feature_flag_manager.is_feature_enabled("SIP_34_SAVED_QUERIES_UI")
-        ):
+        if not app.config["ENABLE_REACT_CRUD_VIEWS"]:
             return super().list()
 
         return super().render_app_template()