[jira] [Commented] (SOLR-9298) solr/contrib/analysis-extras tests fail with maven (SSLTestConfig)

["Steve Rowe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373328#comment-15373328 ] 

Steve Rowe commented on SOLR-9298:
----------------------------------

Christine, I think your patch is the right fix.  I'd do one extra thing though: get rid of the {{<excludes><exclude>\*\*/\*.java</exclude></excludes>}}, which only makes sense when resources are co-located in a {{src/java/}} or {{src/test/}} directory.  (Trivial point here though since {{src/resources/}} doesn't contain any .java files right now.)

Initially I thought the existing resource (all non-.java files in the module) should be preserved, but when I did that (by adding a separate {{<resource>}} for {{src/resources/}} instead of replacing it as your patch does), I can see that the jar actually contains the test keystore twice, one at the root (from the {{src/resources/}} {{<resource>}}), and another at {{src/resources/}}, and the latter is useless (and the cause of this issue).

I'm running tests with your patch locally now.

> solr/contrib/analysis-extras tests fail with maven (SSLTestConfig)
> ------------------------------------------------------------------
>
>                 Key: SOLR-9298
>                 URL: https://issues.apache.org/jira/browse/SOLR-9298
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-9298.patch
>
>
> The error/exception concerned is
> {code}
> java.lang.IllegalStateException: Unable to locate keystore resource file in classpath: SSLTestConfig.testing.keystore
> {code}
> and it seems something similar to the [dev-tools/idea commit|https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6942fe2] in SOLR-8970 is also needed for [dev-tools/maven|https://github.com/apache/lucene-solr/tree/master/dev-tools/maven]'s [solr/test-framework/pom.xml.template|https://github.com/apache/lucene-solr/blob/master/dev-tools/maven/solr/test-framework/pom.xml.template#L61] file.
> Attached patch seems to work but I am new to maven and so would very much appreciate additional input on this. Thank you.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org