You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@avalon.apache.org by bl...@apache.org on 2003/01/23 22:26:14 UTC
cvs commit: jakarta-avalon-excalibur/thread/src/java/org/apache/excalibur/thread/impl DefaultThreadControl.java
bloritsch 2003/01/23 13:26:14
Modified: thread/src/java/org/apache/excalibur/thread/impl
DefaultThreadControl.java
Log:
use a real join command on the thread being controlled
Revision Changes Path
1.5 +1 -13 jakarta-avalon-excalibur/thread/src/java/org/apache/excalibur/thread/impl/DefaultThreadControl.java
Index: DefaultThreadControl.java
===================================================================
RCS file: /home/cvs/jakarta-avalon-excalibur/thread/src/java/org/apache/excalibur/thread/impl/DefaultThreadControl.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- DefaultThreadControl.java 20 Jan 2003 21:18:23 -0000 1.4
+++ DefaultThreadControl.java 23 Jan 2003 21:26:14 -0000 1.5
@@ -91,19 +91,7 @@
public synchronized void join( final long milliSeconds )
throws IllegalStateException, InterruptedException
{
- //final long start = System.currentTimeMillis();
- wait( milliSeconds );
- /*
- if( !isFinished() )
- {
- final long now = System.currentTimeMillis();
- if( start + milliSeconds > now )
- {
- final long remaining = milliSeconds - (now - start);
- join( remaining );
- }
- }
- */
+ m_thread.join(milliSeconds);
}
public void interupt()
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-avalon-excalibur/thread/src/java/org/apache/excalibur/thread/impl DefaultThreadControl.java
Posted by Peter Donald <pe...@realityforge.org>.
You are just asking for deadlock here.
On Fri, 24 Jan 2003 08:26, bloritsch@apache.org wrote:
> bloritsch 2003/01/23 13:26:14
>
> Modified: thread/src/java/org/apache/excalibur/thread/impl
> DefaultThreadControl.java
> Log:
> use a real join command on the thread being controlled
>
> Revision Changes Path
> 1.5 +1 -13
> jakarta-avalon-excalibur/thread/src/java/org/apache/excalibur/thread/impl/D
>efaultThreadControl.java
>
> Index: DefaultThreadControl.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-avalon-excalibur/thread/src/java/org/apache/excalibur/thr
>ead/impl/DefaultThreadControl.java,v retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- DefaultThreadControl.java 20 Jan 2003 21:18:23 -0000 1.4
> +++ DefaultThreadControl.java 23 Jan 2003 21:26:14 -0000 1.5
> @@ -91,19 +91,7 @@
> public synchronized void join( final long milliSeconds )
> throws IllegalStateException, InterruptedException
> {
> - //final long start = System.currentTimeMillis();
> - wait( milliSeconds );
> - /*
> - if( !isFinished() )
> - {
> - final long now = System.currentTimeMillis();
> - if( start + milliSeconds > now )
> - {
> - final long remaining = milliSeconds - (now - start);
> - join( remaining );
> - }
> - }
> - */
> + m_thread.join(milliSeconds);
> }
>
> public void interupt()
--
Cheers,
Peter Donald
*----------------------------------------------------------*
The phrase "computer literate user" really means the person
has been hurt so many times that the scar tissue is thick
enough so he no longer feels the pain.
-- Alan Cooper, The Inmates are Running the Asylum
*----------------------------------------------------------*
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org