[GitHub] [pinot] yuanbenson commented on a diff in pull request #9295: Enable Consistent Data Push for Standalone Segment Push Job Runners

[GitBox <gi...@apache.org>]

yuanbenson commented on code in PR #9295:
URL: https://github.com/apache/pinot/pull/9295#discussion_r964080138


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##########
@@ -370,6 +370,12 @@ public String forDeleteTableWithType(String tableName, String tableType) {
     return StringUtil.join("/", _baseUrl, "tables", tableName + "?type=" + tableType);
   }
 
+  public String forSegmentListAPIWithTableTypeAndExcludeReplacedSegments(String tableName, String tableType,

Review Comment:
   Thanks - unified all under `forSegmentListAPI` and introduced overloaded methods for default parameters. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org