[GitHub] [tvm] apivovarov opened a new pull request #7701: Use dmlc-core as a cmake project

[GitBox <gi...@apache.org>]

apivovarov opened a new pull request #7701:
URL: https://github.com/apache/tvm/pull/7701


   About the problem:
   `dmlc-core` has cmake generated `build_config.h` which enables `DMLC_LOG_STACK_TRACE` in case `cxxabi.h` and `execinfo.h` files are present on the system. This feature (LOG_STACK_TRACE) is used in `dmlc/logging.h` which is used in tvm `runtime/graph/graph_runtime.cc` (via `tvm/runtime/packed_func.h`).
   
   In order to build TVM runtime on a system which does not have `execinfo.h` (e.g. OpenWRT) we need to disable `DMLC_LOG_STACK_TRACE`.
   It will be done automatically if we use `dmlc-core` as a cmake module.
   Currently we simply point tvm build to dmlc-core src and include folders.
   Instead of that we should use dmlc-core as another cmake project.
   
   To verify that the fix works.
   1. Rename `/usr/include/execinfo.h` to smth else
   1. build tvm runtime.
   The build should work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tkonolige commented on pull request #7701: Use dmlc-core as a cmake project

[GitBox <gi...@apache.org>]

tkonolige commented on pull request #7701:
URL: https://github.com/apache/tvm/pull/7701#issuecomment-802402509


   I've proposed this change in the past, but it seems like we want to use dmlc-core as a header only library. @tqchen can provide more info.
   
   You'll be happy to know that #7153 move the stack trace code from dmlc-core into tvm proper. Maybe you should look at that PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] apivovarov closed pull request #7701: Use dmlc-core as a cmake project

[GitBox <gi...@apache.org>]

apivovarov closed pull request #7701:
URL: https://github.com/apache/tvm/pull/7701


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #7701: Use dmlc-core as a cmake project

[GitBox <gi...@apache.org>]

tqchen commented on pull request #7701:
URL: https://github.com/apache/tvm/pull/7701#issuecomment-802408703


   right, the dependency of TVM  on dmlc-core is only limited to the header only, so we do not want to introduce a separate build dep step. Hopefully things can be easier after #7153 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org