You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by trionesadam <gi...@git.apache.org> on 2018/04/26 13:52:42 UTC

[GitHub] flink pull request #5920: [FLINK-9231] [web] Enable SO_REUSEADDR on listen s...

GitHub user trionesadam opened a pull request:

    https://github.com/apache/flink/pull/5920

    [FLINK-9231] [web] Enable SO_REUSEADDR on listen sockets for WebFront…

    ## What is the purpose of the change
    
    Enable SO_REUSEADDR on listen sockets for WebFrontendBootstrap,This allows sockets to be bound even if there are sockets from a previous application that are still pending closure. so we can restart the application at once
    
    ## Brief change log
    
    Enable SO_REUSEADDR on listen sockets for WebFrontendBootstrap, so we add option ChannelOption.SO_REUSEADDR, true for ServerBootstrap.
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): ( no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? ( not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/trionesadam/flink FLINK-9231-WebFrontendBootstrap-enable-address-reuse

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5920.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5920
    
----
commit 1e8096239ed06ae8e42b8e6c14bebaf84333af07
Author: triones.deng <tr...@...>
Date:   2018-04-26T13:40:34Z

    [FLINK-9231] [web] Enable SO_REUSEADDR on listen sockets for WebFrontendBootstrap

----


---

[GitHub] flink issue #5920: [FLINK-9231] [web] Enable SO_REUSEADDR on listen sockets ...

Posted by trionesadam <gi...@git.apache.org>.

Github user trionesadam commented on the issue:

    https://github.com/apache/flink/pull/5920
  
    @zentol i saw that you refactor the WebFrontendBootstrap code. could you please take a look at this PR?


---

[GitHub] flink issue #5920: [FLINK-9231] [web] Enable SO_REUSEADDR on listen sockets ...

Posted by azagrebin <gi...@git.apache.org>.

Github user azagrebin commented on the issue:

    https://github.com/apache/flink/pull/5920
  
    @trionesadam 
    is there still any interest in working on this PR or it can be closed?


---

[GitHub] flink issue #5920: [FLINK-9231] [web] Enable SO_REUSEADDR on listen sockets ...

Posted by tedyu <gi...@git.apache.org>.

Github user tedyu commented on the issue:

    https://github.com/apache/flink/pull/5920
  
    lgtm


---